Bypass uppercase#243
Closed
victorkemp wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
|
Not a good approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two old benchmarks fail because they need lower case matrix names such as:
and
This PR adds a special case test for them in READ_BDF_LINE()
to not uppercase the entire line.
A downside is it means OUTPUT4 and PARTN commands are cases sensitive, unlike everything else.
It's also ugly to test every single card being read. It could be restricted to EC commands.
A proper fix might be to rename
KRRcb,MRRcb,KLR(t)to upper case and not use this PR.