Skip to content

Fix modified inventory with gui for offline player not updating #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benwoo1110 merged 1 commit into from
Jun 5, 2026
+9 −0
Merged

Fix modified inventory with gui for offline player not updating #667

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/main/java/org/mvplugins/multiverse/inventories/view/InventoryDataProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,12 @@
import org.mvplugins.multiverse.inventories.config.InventoriesConfig;
import org.mvplugins.multiverse.inventories.handleshare.SingleShareReader;
import org.mvplugins.multiverse.inventories.handleshare.SingleShareWriter;
import org.mvplugins.multiverse.inventories.profile.ProfileDataSource;
import org.mvplugins.multiverse.inventories.profile.container.ProfileContainer;
import org.mvplugins.multiverse.inventories.profile.container.ProfileContainerStoreProvider;
import org.mvplugins.multiverse.inventories.profile.data.PlayerProfile;
import org.mvplugins.multiverse.inventories.profile.key.ContainerType;
import org.mvplugins.multiverse.inventories.profile.key.GlobalProfileKey;
import org.mvplugins.multiverse.inventories.profile.key.ProfileType;
import org.mvplugins.multiverse.inventories.profile.key.ProfileTypes;
import org.mvplugins.multiverse.inventories.share.Sharable;
Expand All @@ -39,16 +41,19 @@
@Service
public final class InventoryDataProvider {

private final ProfileDataSource profileDataSource;
private final ProfileContainerStoreProvider profileContainerStoreProvider;
private final MultiverseInventories inventories;
private final InventoriesConfig inventoriesConfig;

@Inject
InventoryDataProvider(
@NotNull ProfileDataSource profileDataSource,
@NotNull ProfileContainerStoreProvider profileContainerStoreProvider,
@NotNull MultiverseInventories inventories,
@NotNull InventoriesConfig inventoriesConfig
) {
this.profileDataSource = profileDataSource;
this.profileContainerStoreProvider = profileContainerStoreProvider;
this.inventories = inventories;
this.inventoriesConfig = inventoriesConfig;
Expand Down Expand Up @@ -274,11 +279,15 @@ private void updateOnlinePlayerInventoryData(
) {
// If the target player is online, update their live inventory
if (!targetPlayer.isOnline()) {
// force appy inv data on join
profileDataSource.getGlobalProfile(GlobalProfileKey.of(targetPlayer))
.thenAccept(globalProfile -> globalProfile.setLoadOnLogin(true));
return;
}

Player onlinePlayer = targetPlayer.getPlayer();
if (onlinePlayer == null) {
// this should never happen as we already check if player is online
return;
}

Expand Down
Loading