Implemented a cumulative summation of dV#2185
Open
joal22za wants to merge 2 commits into
Open
Conversation
I added two new columns which sums up the previous stages dV in both Vac and Atmo such that the user doesn't need to manually calculate for example stage 6 to stage 3.
| stageHeaderData.Add(StageData.AtmoDeltaV, (showRcs ? "RCS ∆Vmin" : CachedLocalizer.Instance.MechJebInfoItemsStatsColumn10) + SPACING); | ||
| stageHeaderData.Add(StageData.VacDeltaV, (showRcs ? "RCS ∆Vmax" : CachedLocalizer.Instance.MechJebInfoItemsStatsColumn11) + SPACING); | ||
| stageHeaderData.Add(StageData.AtmoDeltaV, CachedLocalizer.Instance.MechJebInfoItemsStatsColumn10 + SPACING); | ||
| stageHeaderData.Add(StageData.VacDeltaV, CachedLocalizer.Instance.MechJebInfoItemsStatsColumn11 + SPACING); |
Collaborator
There was a problem hiding this comment.
This changes it though so that if you showRcs now you're not getting the correct column heading?
| stageVisibility[StageData.Time] = showTime; | ||
| stageVisibility[StageData.Isp] = showISP; | ||
| stageVisibility[StageData.AtmoCumulativeDeltaV] = showAtmoDeltaV && !showRcs; | ||
| stageVisibility[StageData.VacCumulativeDeltaV] = showVacDeltaV && !showRcs; |
Collaborator
There was a problem hiding this comment.
Also, I'd probably drop the !showRcs check here, and then inside the Calculate* routines to make them showRcs-aware. I'm not certain how much cumulative DV on RCS will be useful to anyone, but I think KER offers that information, and it means columns aren't disappearing and reappearing with that button.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added two new columns which sums up the previous stages dV in both Vac and Atmo such that the user doesn't need to manually calculate for example stage 8 to 4 which are in my case the sum of dV to get into orbit :)
Feel free to ping me on discord @ merineth
I'm in the KSP-RO discord