updated schema for MDS

[sophiemiddleton]

No description provided.

[FNALbuild]

Hi @sophiemiddleton,
You have proposed changes to files in these packages:

• DataProducts

which require these tests: build.

@Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on main.

⌛ The following tests have been triggered for 6a019e5: build (Build queue - API unavailable)

About FNALbuild. Code review on Mu2e/Offline.

[FNALbuild]

☀️ The build tests passed at 6a019e5.

Test	Result	Details
test with	✅	Command did not list any other PRs to include
merge	✅	Merged 6a019e5 at 8a343bd
build (prof)	✅	Log file. Build time: 04 min 16 sec
ceSimReco	✅	Log file.
g4test_03MT	✅	Log file.
transportOnly	✅	Log file.
POT	✅	Log file.
g4study	✅	Log file.
cosmicSimReco	✅	Log file.
cosmicOffSpill	✅	Log file.
ceSteps	✅	Log file.
ceDigi	✅	Log file.
muDauSteps	✅	Log file.
ceMix	✅	Log file.
rootOverlaps	✅	Log file.
g4surfaceCheck	✅	Log file.
trigger	✅	Log file.
check_cmake	✅	Log file.
FIXME, TODO	✅	TODO (0) FIXME (0) in 0 files
clang-tidy	✅	0 errors 0 warnings
whitespace check	✅	no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at 6a019e5 after being merged into the base branch at 8a343bd.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

[brownd1978]

thanks Sophie!

[oksuzian]

Issues found

1. Duplicate #include "canvas/Persistency/Common/Wrapper.h" — classes.h
Wrapper.h is already included at line 6; the PR adds it again at line 31.

  #include "Offline/DataProducts/inc/CrystalId.hh"
-
+#include "canvas/Persistency/Common/Wrapper.h"   // ← duplicate of line 6
+#include "canvas/Persistency/Common/Sampled.h"
 // CRV

Drop the redundant Wrapper.h; keep only the new Sampled.h.

2. New includes placed in the "calorimeter" section
Lines 31–32 land between CrystalId.hh and the // CRV block. These are generic persistency headers — put them with the other canvas/... include at the top (near line 6), not mid-file. Minor, but it removes the blank line the file previously used as a section separator.

3. Indentation inconsistent with the rest of the file — classes_def.xml
Every existing <class> line is indented with a leading space; the 4 new lines start at column 0.

  <class name="art::Wrapper<mu2e::PrescaleFilterFraction>" />
+<class name="map<art::SubRunID,mu2e::PrescaleFilterFraction>"/>
+<class name="map<string,map<art::SubRunID,mu2e::PrescaleFilterFraction> >"/>
+<class name="art::Sampled<mu2e::PrescaleFilterFraction>"/>
+<class name="art::Wrapper<art::Sampled<mu2e::PrescaleFilterFraction> >"/>

Add the leading space to match lines 63–66 for consistency.

4. Verify the map<...> dictionary entries are actually needed
The producers (RandomPrescaleFilter, PrescaleEvent) do subrun.put(...) of a single PrescaleFilterFraction per instance — they don't put a map<SubRunID, PrescaleFilterFraction>. The map<...> and map<string, map<...>> entries look copied from a generic Sampled pattern. Confirm the sampling/MDS read path requires those two map dictionaries; if not, they add dead dictionary entries. The two that are clearly required are art::Sampled<...> and its art::Wrapper<...>.

[FNALbuild]

📝 The HEAD of main has changed to 663de20. Tests are now out of date.