Skip Ollama integration test in CI environments#12
Merged
Conversation
The test 'getContext formats empty results correctly' was attempting to call getContext() which initializes an embedder and tries to connect to Ollama on port 11434. This connection fails in CI environments where Ollama is not running. The test was redundant since: 1. getContext function existence is already tested by the 'exports getContext as a function' test 2. This was an integration test that required external service dependencies 3. Other test suites already verify the core functionality with proper embedder mocking This fix allows the build job to pass without requiring Ollama to be running in CI."
Copilot
AI
changed the title
Fix GitHub Actions build failure: Remove test that requires Ollama
Remove integration test with unmet external dependency in CI
Jun 18, 2026
Copilot created this pull request from a session on behalf of
MrDoe
June 18, 2026 16:28
View session
MrDoe
requested changes
Jun 18, 2026
MrDoe
left a comment
MrDoe
left a comment
Owner
There was a problem hiding this comment.
Disable integration tests dependent on Ollama for Github Action. Then restart Action job.
Modified the 'getContext formats empty results correctly' test to skip when running in CI environments (when process.env.CI is set). This allows the test to run locally during development while being skipped in GitHub Actions where Ollama is not available. The test is preserved as a development/integration test for local environments with Ollama running, rather than being completely removed."
Contributor
Author
Done! I've modified the test to skip when running in CI environments (when Changes in commit cf9c107:
|
Copilot
AI
changed the title
Remove integration test with unmet external dependency in CI
Skip Ollama integration test in CI environments
Jun 18, 2026
MrDoe
approved these changes
Jun 18, 2026
There was a problem hiding this comment.
Pull request overview
Adjusts the programmatic API test suite to avoid failing CI runs when the default embedder (Ollama on 127.0.0.1:11434) is unavailable, keeping the integration-style test runnable for local developers.
Changes:
- Conditionally skips the
getContext formats empty results correctlytest when running under CI.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+35
to
+37
| // Skip this integration test in CI environments where Ollama is not available | ||
| const testFn = process.env.CI ? it.skip : it; | ||
| testFn("getContext formats empty results correctly", async () => { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
npm testcommand in the GitHub Actions build job fails because thegetContext formats empty results correctlytest attempts to initialize an embedder that connects to Ollama on port 11434, which isn't available in the CI environment.Changes
getContext formats empty results correctlytest insrc/__tests__/api.test.tsto skip when running in CIprocess.env.CIis set (GitHub Actions sets this automatically)