Skip to content

COM-3542: Removed popup for login and signup #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
atul-chavan wants to merge 1 commit into
base: develop
Choose a base branch
from
+18 −18
Open

COM-3542: Removed popup for login and signup #347

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 18 additions & 18 deletions scripts/modules/login-links.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,24 +66,24 @@ define(['shim!vendor/bootstrap/js/popover[shim!vendor/bootstrap/js/tooltip[modul
createPopover: function (e) {
// in the absence of JS or in a small viewport, these links go to the login page.
// Prevent them from going there!
var self = this;
if (usePopovers()) {
e.preventDefault();
// If the parent element's not positioned at least relative,
// the popover won't move with a window resize
//var pos = $parent.css('position');
//if (!pos || pos === "static") $parent.css('position', 'relative');
this.$el.popover({
//placement: "auto right",
animation: true,
html: true,
trigger: 'manual',
content: this.template,
container: 'body'
}).on('shown.bs.popover', this.onPopoverShow)
.popover('show');

}
// var self = this;
// if (usePopovers()) {
// e.preventDefault();
// // If the parent element's not positioned at least relative,
// // the popover won't move with a window resize
// //var pos = $parent.css('position');
// //if (!pos || pos === "static") $parent.css('position', 'relative');
// this.$el.popover({
// //placement: "auto right",
// animation: true,
// html: true,
// trigger: 'manual',
// content: this.template,
// container: 'body'
// }).on('shown.bs.popover', this.onPopoverShow)
// .popover('show');

// }
},
retrieveErrorLabel: function (xhr) {
var message = "";
Expand Down