Fix MySQL not supporting unique_fields, add import_id#253
Open
ksy36 wants to merge 1 commit into
Open
Conversation
ksy36
commented
Jul 14, 2026
|
|
||
| if not partial and not to_upsert: | ||
| LOG.error("Full import produced 0 rows — skipping cleanup") | ||
| return |
Collaborator
Author
There was a problem hiding this comment.
This check is to make sure it doesn't delete all ranks if we received empty results from BQ for some reason
skyschub
approved these changes
Jul 17, 2026
skyschub
left a comment
skyschub
left a comment
Collaborator
There was a problem hiding this comment.
We should drop MySQL and rebuild on PG eventually, but oh well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've deployed the changes for importing country ranks and the import job fails with an error
Looks like MySQL doesn't support
unique_fields, so this PR fixes this.Also added
run_idinstead of relying onupdated_at=now()