Skip to content

Show all signature matches when trying to bucket a crash.#593

Draft
jschwartzentruber wants to merge 1 commit into
MozillaSecurity:masterfrom
jschwartzentruber:show-all-sig-matches
Draft

Show all signature matches when trying to bucket a crash.#593
jschwartzentruber wants to merge 1 commit into
MozillaSecurity:masterfrom
jschwartzentruber:show-all-sig-matches

Conversation

@jschwartzentruber
Copy link
Copy Markdown
Contributor

Searching for matching buckets for an unbucketed crash only shows "good" matches, where "good" is fairly arbitrary. Instead show all matches (ordered by quality of the match), and let the user decide.

Searching for matching buckets for an unbucketed crash only shows "good"
matches, where "good" is fairly arbitrary. Instead show all matches
(ordered by quality of the match), and let the user decide.
@jschwartzentruber jschwartzentruber self-assigned this Feb 4, 2020
@jschwartzentruber jschwartzentruber changed the title [crashmanager] Show all signature matches when trying to bucket a crash. Show all signature matches when trying to bucket a crash. Feb 4, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 4, 2020

Codecov Report

❌ Patch coverage is 5.40541% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.01%. Comparing base (a2d82bf) to head (efd2c59).
⚠️ Report is 498 commits behind head on master.

Files with missing lines Patch % Lines
server/crashmanager/views.py 5.40% 35 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #593      +/-   ##
==========================================
- Coverage   66.02%   66.01%   -0.01%     
==========================================
  Files          80       80              
  Lines        7976     7975       -1     
==========================================
- Hits         5266     5265       -1     
  Misses       2710     2710              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jschwartzentruber
Copy link
Copy Markdown
Contributor Author

@choller pointed out that this was a necessary optimization because for many signatures, searching all buckets would be unacceptably slow.

needs further thought to see if both goals can be achieved. (performant and showing more matches)

@jschwartzentruber jschwartzentruber marked this pull request as draft June 10, 2020 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant