Skip to content

fix: correct stale 'rpt did not move' claim in the org-move changelog fragment - #427

Open
d-morrison wants to merge 3 commits into
mainfrom
fix/stale-rpt-did-not-move-421
Open

fix: correct stale 'rpt did not move' claim in the org-move changelog fragment#427
d-morrison wants to merge 3 commits into
mainfrom
fix/stale-rpt-did-not-move-421

Conversation

@d-morrison

@d-morrison d-morrison commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Closes #421

The bug

changelog.d/retarget-doc-urls-after-org-move.fixed.md claimed:

Repositories that did not move -- qwt, rme, rpt -- are untouched.

But rpt has since moved: curl -sI https://github.com/d-morrison/rpt returns 301 -> https://github.com/Morrison-Lab/rpt. That stale claim actively misled an automated review on #408 into flagging a correct Morrison-Lab/rpt link as wrong.

The fix

  1. The changelog fragment: drop rpt from the "did not move" list (leaving qwt, rme) and note that it has since moved -- mirroring the fragment's own existing pattern for the ai-config marketplace ("that stopped holding once ai-config renamed the marketplace itself").
  2. CLAUDE.md:1548 (added during review): the "Prefer the run's own artifacts" bullet carried the same stale implication (qwt, rme, and rpt "appeared in neither [list], so they resolved cleanly"), reading present-tense though rpt has since moved. Added "at the time" / "then" and a snapshot caveat. My original d-morrison/rpt grep missed this because it says just rpt.

Scope: the Ported from d-morrison/rpt provenance references are left as-is

grep -rn d-morrison/rpt finds 10 lines across 9 other files. All are Ported from d-morrison/rpt provenance references -- nearly all plain-text names, plus one still-navigable hyperlink on website/reference/altdoc-multiversion-docs.qmd. These are left unchanged, deliberately:

  • They are accurate historical statements -- the code genuinely was ported from d-morrison/rpt, the repo's name at port time.
  • The 301 redirect keeps every one navigable.
  • This matches the fragment's own stated convention: "Historical entries in CHANGELOG.md and changelog.d/ keep the name the repository had when they were written", and its treatment of the ai-config@d-morrison marketplace identifiers.

The genuine defects were the two false factual claims (rpt "did not move" / "resolved cleanly"), not the provenance names; only those are corrected here.

d-morrison and others added 2 commits August 6, 2026 02:08
…gment

changelog.d/retarget-doc-urls-after-org-move.fixed.md claimed rpt was among
the repositories that 'did not move', but d-morrison/rpt now 301-redirects to
Morrison-Lab/rpt -- and that stale claim misled an automated review on #408
into flagging a correct Morrison-Lab/rpt link as wrong.

Drop rpt from the 'did not move' list (leaving qwt, rme) and note that it has
since moved, mirroring the fragment's existing 'that stopped holding once
ai-config renamed the marketplace' pattern.

The 'Ported from d-morrison/rpt' provenance notes elsewhere (CLAUDE.md, the
website reference page, code comments, the add-altdoc changelog fragment) are
left as-is: they are accurate historical statements (the code WAS ported from
d-morrison/rpt), the redirect keeps them navigable, and this matches the
fragment's own 'historical entries keep the name the repository had when they
were written' convention.

Closes #421

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@d-morrison
d-morrison marked this pull request as ready for review August 6, 2026 09:11
@d-morrison
d-morrison requested a lite review from Copilot August 6, 2026 09:11

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@d-morrison

Copy link
Copy Markdown
Collaborator Author

Good catch, and correct — the PR was empty. I committed the fix locally but marked the PR ready before pushing, so only the empty start: scaffold commit was on the branch. The actual fix is now pushed as e0e7534:

  • changelog.d/retarget-doc-urls-after-org-move.fixed.md:21 now reads Repositories that did not move -- qwt, rme -- are untouched. with a note that rpt has since moved to Morrison-Lab/rpt.
  • gh pr diff 427 --name-only now returns that file (1 file changed).

Re-review of e0e7534 will pick up the real diff. Apologies for the wasted round.

Comment thread changelog.d/retarget-doc-urls-after-org-move.fixed.md Outdated
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

…ision

Review (Ready for merge) surfaced three non-blocking items:

1. CLAUDE.md:1548-1551 ('Prefer the run's own artifacts') carried the same
   stale implication -- 'qwt, rme, and rpt appeared in neither [list], so they
   resolved cleanly' reads present-tense though rpt has since moved. My
   d-morrison/rpt grep missed it (it says just 'rpt'). Added 'at the time' /
   'then' and a snapshot caveat noting rpt has since moved, so it reads as the
   point-in-time observation it is.
2. Changelog parenthetical precision: not all the 'Ported from d-morrison/rpt'
   references are plain names -- one (website/reference/altdoc-multiversion-docs.qmd)
   is a hyperlink. Reworded to 'nearly all plain names, plus one still-navigable
   link'.
3. PR-body reference count corrected (8 -> 10 lines across 9 files) separately.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@d-morrison

Copy link
Copy Markdown
Collaborator Author

ARD summary

First: apologies for the empty first round -- I committed the fix locally but marked the PR ready before pushing. The real fix landed as e0e7534, and this round's review found it correct and "Ready for merge". Addressed all three non-blocking notes in 754b1cf:

  1. Second stale claim (CLAUDE.md:1548): you found another instance my d-morrison/rpt grep missed (it says just rpt). Added "at the time"/"then" and a snapshot caveat noting rpt has since moved -- so the lychee-run observation reads as the point-in-time fact it is.
  2. PR-body count: corrected 8 to 10 lines across 9 files (re-derived).
  3. Inline precision nit: reworded the changelog parenthetical to "nearly all plain names, plus one still-navigable link on the altdoc reference page", since the altdoc reference page one is a hyperlink.

Thread resolved. The provenance-references scope decision (leave the accurate historical Ported from d-morrison/rpt notes) is unchanged and documented in the PR body.

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Claude finished reviewView run


Code review: #427

Since the last review (posted here, verdict Ready for merge), the author pushed one more commit (754b1cf) addressing all three non-blocking notes from that round. I verified each against the current merge commit and the live repo:

  1. CLAUDE.md:1547–1551 stale-claim fix — now reads "...appeared in neither at the time, so they resolved cleanly then... (rpt has since moved to Morrison-Lab/rpt; the point here is the method, and the list is a snapshot of what that specific run found.)" This correctly resolves the prior round's finding 1 (the passage previously read present-tense despite rpt having since moved).

  2. PR-body reference count — corrected from "8" to "10 lines across 9 other files." I re-ran the grep myself (grep -rn "d-morrison/rpt" across .md/.yml/.qmd/.py, excluding the fixed changelog fragment): 9 lines across 8 files, plus CLAUDE.md:419 = 10 lines across 9 files. Matches exactly.

  3. Changelog wording precision (my own prior inline comment on "names rather than links") — reworded to "nearly all plain names, plus one still-navigable link on the altdoc reference page." Accurately reflects that website/reference/altdoc-multiversion-docs.qmd:10 renders as a hyperlink while the rest are plain text.

I also re-verified the core factual claim still holds: curl -sI https://github.com/d-morrison/rpt301https://github.com/Morrison-Lab/rpt.

No new issues in this incremental diff — it's a purely mechanical, well-scoped follow-up that does exactly what the prior review asked for, with no unrelated changes. The prior "Ready for merge" verdict stands and is now further confirmed with the outstanding notes closed out.

Verdict

Ready for merge — prior verdict (comment) confirmed; all three non-blocking notes from that round are now resolved in 754b1cf, and no new findings surfaced.

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

💰 Cost: $1.4979 (review) — run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stale changelog fragment: rpt listed as 'did not move' but d-morrison/rpt now 301-redirects to Morrison-Lab/rpt

2 participants