fix: correct stale 'rpt did not move' claim in the org-move changelog fragment - #427
fix: correct stale 'rpt did not move' claim in the org-move changelog fragment#427d-morrison wants to merge 3 commits into
Conversation
…gment changelog.d/retarget-doc-urls-after-org-move.fixed.md claimed rpt was among the repositories that 'did not move', but d-morrison/rpt now 301-redirects to Morrison-Lab/rpt -- and that stale claim misled an automated review on #408 into flagging a correct Morrison-Lab/rpt link as wrong. Drop rpt from the 'did not move' list (leaving qwt, rme) and note that it has since moved, mirroring the fragment's existing 'that stopped holding once ai-config renamed the marketplace' pattern. The 'Ported from d-morrison/rpt' provenance notes elsewhere (CLAUDE.md, the website reference page, code comments, the add-altdoc changelog fragment) are left as-is: they are accurate historical statements (the code WAS ported from d-morrison/rpt), the redirect keeps them navigable, and this matches the fragment's own 'historical entries keep the name the repository had when they were written' convention. Closes #421 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Good catch, and correct — the PR was empty. I committed the fix locally but marked the PR ready before pushing, so only the empty
Re-review of |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…ision
Review (Ready for merge) surfaced three non-blocking items:
1. CLAUDE.md:1548-1551 ('Prefer the run's own artifacts') carried the same
stale implication -- 'qwt, rme, and rpt appeared in neither [list], so they
resolved cleanly' reads present-tense though rpt has since moved. My
d-morrison/rpt grep missed it (it says just 'rpt'). Added 'at the time' /
'then' and a snapshot caveat noting rpt has since moved, so it reads as the
point-in-time observation it is.
2. Changelog parenthetical precision: not all the 'Ported from d-morrison/rpt'
references are plain names -- one (website/reference/altdoc-multiversion-docs.qmd)
is a hyperlink. Reworded to 'nearly all plain names, plus one still-navigable
link'.
3. PR-body reference count corrected (8 -> 10 lines across 9 files) separately.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
ARD summaryFirst: apologies for the empty first round -- I committed the fix locally but marked the PR ready before pushing. The real fix landed as
Thread resolved. The provenance-references scope decision (leave the accurate historical |
|
Claude finished review — View run Code review: #427Since the last review (posted here, verdict Ready for merge), the author pushed one more commit (
I also re-verified the core factual claim still holds: No new issues in this incremental diff — it's a purely mechanical, well-scoped follow-up that does exactly what the prior review asked for, with no unrelated changes. The prior "Ready for merge" verdict stands and is now further confirmed with the outstanding notes closed out. VerdictReady for merge — prior verdict (comment) confirmed; all three non-blocking notes from that round are now resolved in |
Closes #421
The bug
changelog.d/retarget-doc-urls-after-org-move.fixed.mdclaimed:But
rpthas since moved:curl -sI https://github.com/d-morrison/rptreturns301 -> https://github.com/Morrison-Lab/rpt. That stale claim actively misled an automated review on #408 into flagging a correctMorrison-Lab/rptlink as wrong.The fix
rptfrom the "did not move" list (leavingqwt,rme) and note that it has since moved -- mirroring the fragment's own existing pattern for theai-configmarketplace ("that stopped holding onceai-configrenamed the marketplace itself").CLAUDE.md:1548(added during review): the "Prefer the run's own artifacts" bullet carried the same stale implication (qwt,rme, andrpt"appeared in neither [list], so they resolved cleanly"), reading present-tense thoughrpthas since moved. Added "at the time" / "then" and a snapshot caveat. My originald-morrison/rptgrep missed this because it says justrpt.Scope: the
Ported from d-morrison/rptprovenance references are left as-isgrep -rn d-morrison/rptfinds 10 lines across 9 other files. All arePorted from d-morrison/rptprovenance references -- nearly all plain-text names, plus one still-navigable hyperlink onwebsite/reference/altdoc-multiversion-docs.qmd. These are left unchanged, deliberately:d-morrison/rpt, the repo's name at port time.CHANGELOG.mdandchangelog.d/keep the name the repository had when they were written", and its treatment of theai-config@d-morrisonmarketplace identifiers.The genuine defects were the two false factual claims (
rpt"did not move" / "resolved cleanly"), not the provenance names; only those are corrected here.