fix(agent-core): cap background-task output buffer by bytes, not code units#733
Open
Dmatut7 wants to merge 1 commit into
Open
fix(agent-core): cap background-task output buffer by bytes, not code units#733Dmatut7 wants to merge 1 commit into
Dmatut7 wants to merge 1 commit into
Conversation
… units The in-memory output ring buffer is bounded by `MAX_OUTPUT_BYTES` (1 MiB) and `entry.outputSizeBytes` is tracked with `Buffer.byteLength`, but the eviction loop measured chunks with `string.length` (UTF-16 code units). For multibyte output (CJK, emoji) the resident buffer could therefore grow well past the byte cap — e.g. ~3 MiB of 3-byte characters before any eviction — defeating the memory bound the constant promises. Measure eviction in UTF-8 bytes so the cap holds regardless of encoding. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
No existing issue — internal memory-bound fix explained below.
Problem
The in-memory background-task output ring buffer is bounded by
MAX_OUTPUT_BYTES(1 MiB) andentry.outputSizeBytesis tracked withBuffer.byteLength, but the eviction loop measured chunks withstring.length(UTF-16 code units). For multibyte output (CJK, emoji) the resident buffer could grow well past the byte cap (~3 MiB of 3-byte characters before any eviction), defeating the memory bound.What changed
Measure eviction in UTF-8 bytes so the cap holds regardless of encoding. Test added.
Checklist