fix(tui): update pi-tui for kitty backspace#718
Conversation
🦋 Changeset detectedLatest commit: d45d7b0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d8bba2c560
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| parent: 'pi-tui', | ||
| nativeFileRelatives: (target) => [`build/koffi/${koffiTripletByTarget[target]}/koffi.node`], | ||
| }, | ||
| ]); |
There was a problem hiding this comment.
When building the native SEA artifacts for Windows/macOS, the bumped @earendil-works/pi-tui@0.79.3 now loads its own .node helpers from native/win32/.../win32-console-mode.node and native/darwin/.../darwin-modifiers.node, but this registry now only collects the clipboard packages and scripts/native/package.mjs zips only the executable. Those helpers will be absent from the native release, so Windows VT input support for modified keys such as Shift+Tab, and Apple Terminal Shift+Enter detection, silently regress. Please either collect/copy pi-tui's native files or otherwise make them available next to the native executable.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
fixed in d45d7b0 — pi-tui helpers now get copied next to the native executable and included in the release zip.
also added macOS signing/verification for those helpers, included the sibling native/ dir in the notary submission, and made the native smoke check fail if the helper is missing.
1 participant
Summary
@earendil-works/pi-tuito^0.79.3so Kitty keyboard protocol negotiation uses the upstream fix.koffinative asset handling that is no longer needed by the updatedpi-tuipackage.@moonshot-ai/kimi-code.Resolve #704
Testing
pnpm lintpnpm typecheckpnpm testpnpm --filter @moonshot-ai/kimi-code exec vitest run test/scripts/native/native-deps.test.tsnode --input-type=module -e "import { collectNativeAssets } from './apps/kimi-code/scripts/native/assets.mjs'; const r = await collectNativeAssets({ appRoot: './apps/kimi-code', target: 'darwin-arm64' }); console.log(r.manifest.packages.map((p) => p.name).join('\n'));"git diff --checkAI Assistance Disclosure
I used Codex to review the changes, sanity-check the implementation against existing patterns, and help spot potential edge cases.