refactor(agent-core-v2): extract btw into a features/btw Feature unit - #2724
Open
sailist wants to merge 1 commit into
Open
refactor(agent-core-v2): extract btw into a features/btw Feature unit#2724sailist wants to merge 1 commit into
sailist wants to merge 1 commit into
Conversation
- move session/btw to features/btw, mirroring the plan feature layout - contribute ISessionBtwService at Session scope through BtwFeature (contributeService) instead of a static registerScopedService call - keep the package root exports unchanged; move the test to test/features/btw
|
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
No linked issue — the problem is explained below.
Problem
btw(the side-question child-agent capability) still lived in the Session domain (src/session/btw) with a staticregisterScopedServiceregistration, whilesrc/features/is the established seam for self-contained built-in capabilities (planwas the first). Staying outside the Feature mechanism means btw is not a named, introspectable, individually retractable unit inIFeatureManager.What changed
src/session/btw/tosrc/features/btw/, mirroring theplanfeature layout.BtwFeature(features/btw/btwFeature.ts), which contributesISessionBtwServiceat Session scope throughcontributeService. Activation stays eager, matching the previousOnScopeCreatedbehavior; retracting the unit now withdraws the service across the scope tree.registerScopedServicecall frombtwService.ts. Package root exports are unchanged, so kap-server / node-sdk consumers are unaffected.test/features/btw/.Verified:
lint:imports,typecheck, and the full agent-core-v2 suite (310 files / 4891 tests) all pass. No changeset: internal engine refactor with no user-perceivable change.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.