feat: persist approve_for_session decisions across session resume#1469
Closed
Br1an67 wants to merge 1 commit intoMoonshotAI:mainfrom
Closed
feat: persist approve_for_session decisions across session resume#1469Br1an67 wants to merge 1 commit intoMoonshotAI:mainfrom
Br1an67 wants to merge 1 commit intoMoonshotAI:mainfrom
Conversation
When resuming a session, actions previously approved via 'approve for session' were lost because the approval state was only kept in memory. Persist auto_approve_actions to approval_state.json in the session directory. Load them on session restore so users don't need to re-approve the same actions repeatedly. Fixes MoonshotAI#765
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Author
|
Closing this PR — approval state persistence was independently implemented on main via commit 600ff8f which uses the existing session state system with an |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When resuming a session, actions previously approved via 'approve for session' are lost because
ApprovalState.auto_approve_actionsis only kept in memory (there's a TODO comment about this).Fix
session_dirparameter toApprovalStateandApprovalauto_approve_actionstoapproval_state.jsonin the session directorysession.dirfromRuntime.create()Deleting the state file resets approvals, as expected.
Fixes #765