fix: add asyncio lock to context file writes#1467
Open
Br1an67 wants to merge 1 commit intoMoonshotAI:mainfrom
Open
fix: add asyncio lock to context file writes#1467Br1an67 wants to merge 1 commit intoMoonshotAI:mainfrom
Br1an67 wants to merge 1 commit intoMoonshotAI:mainfrom
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
On Windows, concurrent async writes to the context.jsonl file can cause PermissionError due to file locking semantics. Multiple coroutines (append_message, update_token_count, checkpoint) may attempt to write simultaneously. Add an asyncio.Lock to serialize all file write operations in the Context class, preventing concurrent access to the context file. Fixes MoonshotAI#1429
Br1an67
force-pushed
the
fix/context-write-lock
branch
from
64d5181 to
93cdfb2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Windows, concurrent async writes to
context.jsonlcausePermissionErrordue to file locking semantics. Multiple coroutines (append_message,update_token_count,checkpoint) may write simultaneously.Fix
Add an
asyncio.Lockto theContextclass to serialize all file write operations (checkpoint,append_message,update_token_count).Fixes #1429