fix: escape Rich markup in error and user content to prevent crashes#1462
Open
Br1an67 wants to merge 1 commit intoMoonshotAI:mainfrom
Open
fix: escape Rich markup in error and user content to prevent crashes#1462Br1an67 wants to merge 1 commit intoMoonshotAI:mainfrom
Br1an67 wants to merge 1 commit intoMoonshotAI:mainfrom
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
When user input or error messages contain text resembling Rich markup tags (e.g., [/login]), rich.print() tries to interpret them as formatting tags, causing MarkupError crashes. Escape all dynamic content passed to rich.print() in print mode using rich.markup.escape() to prevent Rich from interpreting brackets as markup. Fixes MoonshotAI#1291
Br1an67
force-pushed
the
fix/rich-markup-escape
branch
from
094f338 to
8fd1842
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In print mode,
from rich import printreplaces the builtin print. When error messages or user input contain text resembling Rich markup tags (e.g.,[/login]), Rich throwsMarkupError, crashing the CLI.Stack trace starts at
ui/print/__init__.py→rich.console.print→rich.markup.render.Fix
Escape all dynamic content with
rich.markup.escape()before passing toprint()inui/print/__init__.py.Fixes #1291