Skip to content

feat(cli): add official wire file support and build-web command#1457

Open
Nietzsche-Ubermensch wants to merge 2 commits intoMoonshotAI:mainfrom
Nietzsche-Ubermensch:agent/from-pathlib-import-path-import-re-p-pathmntdataki-75-l3-blackbox
Open

feat(cli): add official wire file support and build-web command#1457
Nietzsche-Ubermensch wants to merge 2 commits intoMoonshotAI:mainfrom
Nietzsche-Ubermensch:agent/from-pathlib-import-path-import-re-p-pathmntdataki-75-l3-blackbox

Conversation

@Nietzsche-Ubermensch
Copy link

@Nietzsche-Ubermensch Nietzsche-Ubermensch commented Mar 17, 2026

Related Issue

Resolve #(issue_number)

Description

Checklist

  • I have read the CONTRIBUTING document.
  • I have linked the related issue, if any.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have run make gen-changelog to update the changelog.
  • I have run make gen-docs to update the user documentation.

Open with Devin

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cf49592e94

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +4 to +5
p = Path('/mnt/data/kimi_enterprise_complete.py')
text = p.read_text(encoding='utf-8')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Parameterize the patch target file path

The script hardcodes '/mnt/data/kimi_enterprise_complete.py' and immediately calls read_text(), so in a normal checkout it fails with FileNotFoundError before applying any patch. This makes the committed tool unusable outside one specific machine path and prevents the feature from being applied in CI or by other developers.

Useful? React with 👍 / 👎.

Comment on lines +283 to +287
' sub.add_parser("print-sdk-setup", help="Print Kimi Agent SDK / Wire setup instructions")\n',
' sub.add_parser("print-sdk-setup", help="Print Kimi Agent SDK / Wire setup instructions")\n'
' webbuild = sub.add_parser("build-web", help="Build and sync the web UI into src/kimi_cli/web/static")\n'
' webbuild.add_argument("--root", default=".", help="Repository root containing web/ and pyproject.toml")\n'
)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Guard build-web replacements to keep the patch idempotent

These parser replacements run unconditionally even when build_web_ui already exists, so re-running the patch script will append another build-web subparser registration and duplicate command handling. In argparse, duplicate subparser names raise ValueError: conflicting subparser, so a second run can leave the patched CLI script broken.

Useful? React with 👍 / 👎.

Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 5 additional findings.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant