fix(chat): correct button type to buttons in web chat#1446
Open
HynoR wants to merge 1 commit intoMoonshotAI:mainfrom
Open
fix(chat): correct button type to buttons in web chat#1446HynoR wants to merge 1 commit intoMoonshotAI:mainfrom
HynoR wants to merge 1 commit intoMoonshotAI:mainfrom
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an issue in the web chat composer where clicking non-submit controls (notably the attachment button) could trigger an unintended form submit, causing the current prompt text to be sent.
Changes:
- Add
type="button"to the attachment button inGlobalConfigControlsto prevent implicit form submission. - Add
type="button"to otherButton-based controls in the same toolbar (model selector trigger, restart busy sessions, reload config) to ensure consistent non-submit behavior inside the prompt<form>.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Resolve #1428
Description
add button type in each button like element to avoid global submit when clicking file upload button.
Checklist
make gen-changelogto update the changelog.make gen-docsto update the user documentation.