Moved Modifier from SysMLBasis to SysMLv2 - #202
Draft
martinmar wants to merge 3 commits into
Draft
Conversation
martinmar
marked this pull request as draft
August 11, 2026 15:20
martinmar
marked this pull request as ready for review
August 11, 2026 21:49
Contributor
|
Verbesserung messen, Rebase machen, Version erhöhen |
mathias-pfeiffer
marked this pull request as draft
August 12, 2026 12:31
martinmar
force-pushed
the
martin/moving-Modifier
branch
2 times, most recently
from
August 19, 2026 06:12
98e9fe2 to
ad21ec3
Compare
martinmar
marked this pull request as ready for review
August 19, 2026 07:39
CoCos und Completer mussten angepasst werden, damit die Methoden isIn(), isOut() und isReturn() korrekt benutzt werden
Der Import wurde an die Verschiebung angepasst und die Fehler behoben
Da SysMLUsage nun auch einen Modifier verwendet, gab es matching probleme mit UML Modifier und SysMLv2 Modifier. Ein manueller Override behebt das Problem
martinmar
force-pushed
the
martin/moving-Modifier
branch
from
August 20, 2026 12:20
02b9569 to
ce0a7cd
Compare
| public class ASTUserDefinedUsage extends ASTUserDefinedUsageTOP { | ||
|
|
||
| @Override | ||
| public void setModifier(de.monticore.umlmodifier._ast.ASTModifier modifier) { |
Contributor
There was a problem hiding this comment.
Erklärung nötig
Suggested change
| public void setModifier(de.monticore.umlmodifier._ast.ASTModifier modifier) { | |
| /** | |
| * TBD | |
| */ | |
| public void setModifier(de.monticore.umlmodifier._ast.ASTModifier modifier) { |
mathias-pfeiffer
marked this pull request as draft
August 20, 2026 12:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed
isIn(),isOut()undisReturn()verwenden, wurden angepasstVerbesserung (in ms)
vorher Average: 3984,466333
nachher Average: 3968,59118
Verbesserung: ~0,4%