CoCo for defs and usages having the same type by Deni1593 · Pull Request #147 · MontiCore/sysmlv2

Deni1593 · 2026-06-03T09:26:29Z

Implemented:

DefsAndUsagesHaveTheSameTypeCoCo.java: a coco that checks if defs and usages have the same type. Contains 4 check() functions, one for each of part, port, enum and attribute. Attributes can be typed both by 'attribute' and by standard library types

DefsAndUsagesHaveTheSameTypeTest: tests if the def and usage within the given model have the same type

adriancostin-sd

Remember to rebase/merge the main branch into yours and whenever you are working on an issue just create a fresh branch not together with other previous issues. Also update the PR description

adriancostin-sd · 2026-08-17T11:57:53Z

+        .anyMatch(t -> node.getEnclosingScope()
+            .resolvePartDef(t.getSuperTypes(0).printType())
+            .isPresent());


Suggested change

.anyMatch(t -> node.getEnclosingScope()

.resolvePartDef(t.getSuperTypes(0).printType())

.isPresent());

.flatMap(t -> getSuperTypesList())

.map(t -> ((ISysMLv2Scope)t.getEnclosingScope()).resolvePartDef(t.printType()))

.allMatch(t -> t.isPresent())

The idea is, if it has a typing then see if it is the right definition, therefore allMatch

adriancostin-sd · 2026-08-17T11:58:21Z

+   /* node.getSymbol().getTypesList().stream()
+        .filter(t -> !(t.getTypeInfo() instanceof PartDef2TypeSymbolAdapter))// This type actually came from a part def
+        .forEach(t -> Log.error(
+            "0xCOCO001 Part usages must be typed by part definitions, but found: "
+                + t.print(),
+            node.get_SourcePositionStart(),
+            node.get_SourcePositionEnd()));*/
+  }


Suggested change

/* node.getSymbol().getTypesList().stream()

.filter(t -> !(t.getTypeInfo() instanceof PartDef2TypeSymbolAdapter))// This type actually came from a part def

.forEach(t -> Log.error(

"0xCOCO001 Part usages must be typed by part definitions, but found: "

+ t.print(),

node.get_SourcePositionStart(),

node.get_SourcePositionEnd()));*/

}

adriancostin-sd · 2026-08-17T12:02:38Z

+    checker.addCoCo((SysMLPartsASTPortUsageCoCo) new DefsAndUsagesHaveTheSameTypeCoCo());
+    Log.enableFailQuick(false);
+    checker.checkAll((ASTSysMLv2Node) as.getAstNode());
+    System.out.println("HERE:" + Log.getFindings());


Suggested change

System.out.println("HERE:" + Log.getFindings());

This pollutes the output

adriancostin-sd · 2026-08-17T13:05:41Z

-      "packages.sysml",
-      "imports.sysml",
-      "ports.sysml",
-      "parts.sysml",
-      "states.sysml",
-      "parallel_states.sysml",
-      "actions.sysml",
-      "items.sysml",
-      "assert.sysml",
-      "constraints.sysml",
-      "requirements.sysml",
-      "streams.sysml",
-      "refinement.sysml",
-      "cardinalities.sysml",
-      "connections.sysml",
-      "collections.sysml",
-      "StateDecomposition1.sysml",
-      "FlowConectionInterfaceExample.sysml",
-      "StateActions.sysml",
-      "ConditionalSuccessionExample-1.sysml"
+      "example.sysml"
+      //"packages.sysml",
+     // "imports.sysml",
+      //"ports.sysml",
+     // "parts.sysml",
+     // "states.sysml",
+      //"parallel_states.sysml",
+      //"actions.sysml",
+     // "items.sysml",
+     // "assert.sysml",
+     // "constraints.sysml",
+     // "requirements.sysml",
+     // "streams.sysml",
+     // "refinement.sysml",
+     // "cardinalities.sysml",
+     // "connections.sysml",
+     // "collections.sysml",
+     // "StateDecomposition1.sysml",
+    //  "FlowConectionInterfaceExample.sysml",
+     // "StateActions.sysml",
+     // "ConditionalSuccessionExample-1.sysml"


adriancostin-sd · 2026-08-17T13:05:52Z

+
+
+
+


adriancostin-sd · 2026-08-17T13:06:55Z

+standard library package AnalysisTooling {
+    private import ScalarValues::*;
+
+    metadata def ToolExecution {
+      attribute toolName : String;
+      attribute uri : String;
+      }
+    metadata def ToolVariable {
+    attribute name : String;
+    }
+}


where is this coming from?

i think i copied it from the release notes to test standard library types for attributes, but I can delete it, it is not essential.

adriancostin-sd · 2026-08-17T13:07:32Z

revert the test completely

adriancostin-sd · 2026-08-17T13:08:03Z

revert this test as well and merge the main branch into yours

adriancostin-sd · 2026-08-21T12:29:33Z

  public void init() {
    tool.init();
    Log.init();
+


Suggested change

adriancostin-sd · 2026-08-21T12:29:41Z


  static SysMLv2Tool tool;

+


Suggested change

adriancostin-sd · 2026-08-21T12:29:48Z


 import static org.assertj.core.api.Assertions.assertThat;

+


Suggested change

adriancostin-sd · 2026-08-21T12:29:53Z

 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.Disabled;

+


Suggested change

adriancostin-sd · 2026-08-21T12:32:06Z

    assertThat(ast).isPresent();
    assertThat(Log.getFindings()).isEmpty();
  }
-


dont delete lines without a reason

adriancostin-sd · 2026-08-21T12:35:00Z

-      //"imports.sysml",
+      "imports.sysml",
      "ports.sysml",
-      //"parts.sysml",
-      //"states.sysml",
+      "parts.sysml",
+      "states.sysml",
      "parallel_states.sysml",
-      //"actions.sysml",
+      "actions.sysml",
      "items.sysml",
      "assert.sysml",
-      //"constraints.sysml",
+      "constraints.sysml",
      "requirements.sysml",
-      //"streams.sysml",
-      //"streamsFilter.sysml",
-      //"refinement.sysml",
+      "streams.sysml",
+      "streamsFilter.sysml",
+      "refinement.sysml",
      "cardinalities.sysml",
      "connections.sysml",
-      //"collections.sysml",
+      "collections.sysml",
      "StateDecomposition1.sysml",
-      //"FlowConectionInterfaceExample.sysml",
+      "FlowConectionInterfaceExample.sysml",
      "StateActions.sysml",
      "ConditionalSuccessionExample-1.sysml"


Leave them commented out until we fix the parser in another PR

adriancostin-sd · 2026-08-21T13:05:59Z

Revert these changes please.

adriancostin-sd · 2026-08-21T13:17:40Z

+  }
+
+  @Test
+  public void testInvalid() throws IOException {


rename to shouldReportError

adriancostin-sd · 2026-08-21T13:17:51Z

+  }
+
+  @Test
+  public void testValid() throws IOException {


rename to shouldNotReportError

adriancostin-sd · 2026-08-21T13:18:38Z

+
+  @Test
+  public void testInvalid() throws IOException {
+    var as = process("attribute def P; attribute d: P;");


in this case the def should have another type to detect an error

adriancostin-sd requested changes Aug 17, 2026

View reviewed changes

Deni1593 added 5 commits August 20, 2026 13:01

coco to be reviewed

86f4250

test hopefully ready

362811a

coco and test hopefully ready

3c04194

tests run as expected

064a8db

requested changes implemented

66ca8c5

Deni1593 force-pushed the fixing-grammars-issue-119 branch from 6d8d266 to 66ca8c5 Compare August 21, 2026 09:38

Deni1593 changed the title ~~Possible grammar fix for imports.sysml~~ CoCo for defs and usages having the same type Aug 21, 2026

adriancostin-sd requested changes Aug 21, 2026

View reviewed changes

Deni1593 added 2 commits August 21, 2026 17:15

hopefully fixes pipeline, added more methods for the defs-usages checks

c4e3b33

hopefully fixes pipeline #2

e6788f1

		import org.junit.jupiter.api.Test;
		import org.junit.jupiter.api.Disabled;

Uh oh!

Conversation

Deni1593 commented Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adriancostin-sd left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Deni1593 commented Jun 3, 2026 •

edited

Loading