Skip to content

Make Helmets selectable for Royal Knights#5308

Merged
CheffieGithub merged 8 commits intoMonkestation:mainfrom
Snack-Max:RK-SelectableHelm
Feb 22, 2026
Merged

Make Helmets selectable for Royal Knights#5308
CheffieGithub merged 8 commits intoMonkestation:mainfrom
Snack-Max:RK-SelectableHelm

Conversation

@Snack-Max
Copy link
Copy Markdown

@Snack-Max Snack-Max commented Feb 18, 2026

image

About The Pull Request

Allow Royal Knights to select helmets (note will need assistant from more experienced coders to allow the royal knight advance class select both helmet and weapons, only giving options for helmet for Royal knight advclass)

Why It's Good For The Game

Allows Royal Knights players to customize their characters more (also if disgraced knights/deserters are allowed to so should the loyal knights)

Changelog

🆑
add: Allow Royal Knight Advclass to choose their helmets
/:cl:

Pre-Merge Checklist

  • You tested this on a local server.
  • This code did not runtime during testing.
  • You documented all of your changes.

Allow Royal Knights to select helmets (note will need assistant from more experienced coders to allow the royal knight advance class select both helmet and weapons, only giving options for  helmet for Royal knight advclass)
@github-actions github-actions Bot added the Feature adds a new thing label Feb 18, 2026
@Snack-Max
Copy link
Copy Markdown
Author

image

Comment thread code/modules/jobs/job_types/garrison/royal_knight.dm Outdated
Comment thread code/modules/jobs/job_types/garrison/royal_knight.dm Outdated
Comment thread code/modules/jobs/job_types/garrison/royal_knight.dm Outdated
Comment thread code/modules/jobs/job_types/garrison/royal_knight.dm Outdated
Comment thread code/modules/jobs/job_types/garrison/royal_knight.dm Outdated
Snack-Max and others added 5 commits February 20, 2026 12:54
Co-authored-by: CheffieGithub <113442598+CheffieGithub@users.noreply.github.com>
Co-authored-by: CheffieGithub <113442598+CheffieGithub@users.noreply.github.com>
Co-authored-by: CheffieGithub <113442598+CheffieGithub@users.noreply.github.com>
Co-authored-by: CheffieGithub <113442598+CheffieGithub@users.noreply.github.com>
Co-authored-by: CheffieGithub <113442598+CheffieGithub@users.noreply.github.com>
@Snack-Max
Copy link
Copy Markdown
Author

Didnt realized the bastion was too strong, thanks for checking that for me @CheffieGithub

Comment thread code/modules/jobs/job_types/garrison/royal_knight.dm Outdated
@CheffieGithub
Copy link
Copy Markdown
Collaborator

Really I think royalknight has too many selectables already but we'll see

@Snack-Max
Copy link
Copy Markdown
Author

Really I think royalknight has too many selectables already but we'll see

Is there another helmet i should remove like the decorated helmet or what do you think? I personally prefer that atleast the sallet selection stays

@CheffieGithub CheffieGithub merged commit a1b715f into Monkestation:main Feb 22, 2026
17 checks passed
github-actions Bot added a commit that referenced this pull request Feb 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature adds a new thing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants