Conversation
github-actions
Bot
added
the
Code Maintenance
KevinfromHP
left a comment
KevinfromHP
left a comment
There was a problem hiding this comment.
could you separate the sellprice defines into a new file
| throw_speed = 4 | ||
| max_integrity = INTEGRITY_POOR | ||
| embedding = list("embedded_pain_multiplier" = 4, "embed_chance" = 50, "embedded_fall_chance" = 0) | ||
| sellprice = 65 | ||
| sellprice = VALUE_SILVER_ITEM | ||
| melting_material = /datum/material/silver | ||
|
|
There was a problem hiding this comment.
this would mean each dagger is worth 42 mammon, we gotta cut that down hard
| max_integrity = INTEGRITY_STRONG | ||
| sellprice = 10 | ||
| sellprice = VALUE_WOOD_ITEM | ||
|
|
There was a problem hiding this comment.
your pricing is ending up inconsistent, this is actually worth less than a wooden staff
There was a problem hiding this comment.
I will double check everything to fix all my oversights
KevinfromHP
left a comment
KevinfromHP
left a comment
There was a problem hiding this comment.
It's fine? But it's not really what I need, this should mostly follow the chain of crafting more than generic items.
Yeah, I gotta make sure craftable recipe sellprice is consistent, I missed quite a few. I can't figure out how the proc to do it automatically works. |
github-actions
Bot
added
the
MERGE CONFLICT
github-actions
Bot
removed
the
MERGE CONFLICT
|
i'll just deal with this in the future |
2 participants
About The Pull Request
Turns almost all sellprice values into defines.
A lot of values changed: currently makes a lot of stuff way less expensive.
Need to make sure define values are good
ingot values:
IRON = 12
STEEL = 24
SILVER = 36
GOLD = 60
BLACKSTEEL = 72
Why It's Good For The Game
Changelog
🆑
code: sellprices values switched to define
/:cl:
Pre-Merge Checklist