Replace manual disconnect teardown with owner resets - #91
Draft
ctoth wants to merge 3 commits into
Draft
Conversation
ctoth
force-pushed
the
agent/issue-78-disconnect-registry
branch
from
July 29, 2026 19:33
7471aa4 to
d77a944
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MudClient's manual feature roll-call to the feature owners while preserving history, input, preferences, editor state, and lifetime listenersRoot cause and impact
Disconnect cleanup had accumulated as a centralized list in
MudClient, so new stateful packages could be added without joining the teardown path. That left session state behind across reconnects. The local transport path also retained stale references, and command sends could reach closed or missing transports after local echo had already been recorded.This PR makes disconnect ownership explicit at package registration, preserves the file-transfer-before-GMCP cleanup ordering, and surfaces closed-transport command failures without false local echo.
Validation
npm test— 104 files, 1,050 testsnpm run typechecknpm run buildgit diff --check origin/master..HEADFixes #78
Fixes #60