Fix inc/dec rejecting deltas outside a field's min_value/max_value - #2914
Open
DSeaStar wants to merge 1 commit into
Open
Fix inc/dec rejecting deltas outside a field's min_value/max_value#2914DSeaStar wants to merge 1 commit into
DSeaStar wants to merge 1 commit into
Conversation
$inc/$dec apply a delta, not the stored value, so min/max validation must not run against the increment (see MongoEngine#2339).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$inc/$decapply a delta, not the stored field value.prepare_query_value()was still runningvalidate(), so a field withmin_value=0rejected any decrement (dec__amount=10→ delta-10→ "value is too small"). The same happens forincwhenmax_valueis set.inc/decoperators only.setand other update operators still validate as before.Test plan
transform.update(Account, dec__amount=10)onFloatField(min_value=0)now emits{'$inc': {'amount': -10.0}}IntField/DecimalFielddecrementsset__amount=-1still raisesValidationErrortest_transform_update_inc_dec_ignores_min_max