Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
BCLConvert create fastq files for samples even in cases where no reads are assigned to the sample, resulting in empty fastq files. This break fastq_screen.
This PR adds a filter to remove empty fastqs from the channel.
Risk analysis
No risks identified. Unit tests seem to confirm that the filter is working properly.
Validation procedure
Test data updated with a set of empty fastq files. I could confirm that the pipeline failed before the change to main.nf but not after. Will also be verified in https://snpseq.atlassian.net/wiki/spaces/AR/pages/3983933457/Verification+of+snpseq_packs+v9.0.0