[202_109] allow the comment author name to be modified directly from floating toolbar#2902
Open
1sh-repalto wants to merge 2 commits intoMoganLab:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2714
In the Comment plugin, the name cannot be modified in the floating toolbar
Summary
Allow the comment author name (
byfield) to be modified directly from the floating toolbar by showing a text input widgetDeveloper document:
devel/202_109.mdIssue Found
In
comment-menu.scm, thefocus-hidden-iconsmenu override for comment contexts had an empty body, which completely suppressed all hidden child input widgets from the focus toolbar. This prevented users from modifying the author name when clicking on a comment tag.;; Before: empty body — no hidden child inputs shown (tm-menu (focus-hidden-icons t) (:require (any-comment-context? t)))Changes
Added
(dynamic (string-input-icon t 3))to thefocus-hidden-iconsoverride inTeXmacs/plugins/comment/progs/various/comment-menu.scmto render a text input widget for child index 3 (theby/author name field).How to Test
commentstyle package is loadedInsert -> Note -> Unfolded comment