[222_45] compact toolbar and fix native menu bar empty strip (#2877)#2878
Open
AnvarAtayev wants to merge 1 commit intoMoganLab:mainfrom
Open
[222_45] compact toolbar and fix native menu bar empty strip (#2877)#2878AnvarAtayev wants to merge 1 commit intoMoganLab:mainfrom
AnvarAtayev wants to merge 1 commit intoMoganLab:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes Issue #2877
Summary
Two related UI improvements for the liii/liii-night themes on macOS:
use_native_menubaris enabled, themenuToolBarcontainer remained visible at full height even though its content moved to the system menu bar. The toolbar is now hidden in this case.Also removes an incorrect
setFixedHeight(108 * devicePixelRatio)on theQMenuBarwidget, which was setting a physical-pixel value on a logical-pixel widget (resulting in a 216 px tall menu bar on Retina displays).Files Changed
TeXmacs/misc/themes/liii.cssTeXmacs/misc/themes/liii-night.csssrc/Plugins/Qt/qt_tm_widget.cppHow to Test
liii) theme; verify toolbar rows are more compactuse_native_menubarin Preferences -> User Interface; verify no empty strip remains below the title baruse_native_menubar; verify the in-window menu bar returns correctlyOLD -

use_nativebar=TrueOLD -

use_nativebar=FalseNEW
