Conversation
Undline
commented
Apr 6, 2026
Undline
commented
- Methods: card-style editors for standard metrics and validator pie; hidden metric params; preserve hidden values when switching methods; validate only visible required fields; cap custom dashboard cards; move health CSV block last.
- reportModuleStateDetail: constants and compose/build helpers aligned with UI.
- Core: require integer schema_version and granularity_hours; reject NaN/Inf health_activity points; add tests.
- Frontend dev: webpack poll/debounce for all compilers on win32; optional NEXT_WEBPACK_POLL_MS; npm run dev:incremental skips .next clean.
…tion; Windows dev HMR - Methods: card-style editors for standard metrics and validator pie; hidden metric params; preserve hidden values when switching methods; validate only visible required fields; cap custom dashboard cards; move health CSV block last. - reportModuleStateDetail: constants and compose/build helpers aligned with UI. - Core: require integer schema_version and granularity_hours; reject NaN/Inf health_activity points; add tests. - Frontend dev: webpack poll/debounce for all compilers on win32; optional NEXT_WEBPACK_POLL_MS; npm run dev:incremental skips .next clean. Made-with: Cursor
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b2a865f424
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const next: Record<string, string> = {}; | ||
| for (const p of def.params) { | ||
| if (p.hidden) { | ||
| next[p.name] = prev[p.name] ?? ""; | ||
| } else if (p.options?.length) { |
There was a problem hiding this comment.
Rebuilding state in buildInitialValuesForMethod from only the newly selected method’s params drops keys that aren’t in that method. For report_module_state, this means hidden dashboard fields are lost as soon as the user switches to another method, and switching back restores them as empty strings instead of preserving prior input. This creates repeated data loss during normal navigation and undermines the hidden-field preservation this change is trying to provide.
Useful? React with 👍 / 👎.
1 participant
