Conversation
Added - Side effect action and timestamp handling in the abstraction layer - Audit entry coverage for mutation side effects - Workflow approvals scenario dedicated to observable side effects - Side effect emission examples for workflow start and workflow rejection Changed - Runtime audit entry creation now carries side effects through the execution pipeline - Mutation result logging now prints emitted side effects with severity and action flags - Rejected workflow scenario now executes an explicit rejection path after blocking policy decision - ADR-006 status now reflects the accepted side effect design Result Side effects are now part of the runtime audit flow and are demonstrated in the runnable workflow example, including critical effects that require follow up action.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add side effect support to the runtime audit flow and demonstrate it in the workflow approvals example.
Added
WorkflowApprovalsChanged
SideEffect.Create(...)now supports explicitRequiresActionand timestamp valuesSideEffect.Critical(...)now always marks the effect as requiring follow-up actionMutationResult.SideEffectsthrough to audit recordsResult
Side effects now move through the runtime audit path consistently and have a runnable example that shows both standard and critical effects, including the
RequiresActionflag.Testing
dotnet build src/ModularityKit.Mutator.csproj -c Releasedotnet build Examples/WorkflowApprovals/WorkflowApprovals.csproj -c ReleaseLinked Issues
Checklist