✨ Feat: add ASSET_OWNER role, enforce asset visibility, and refine no…#3042
Open
Lifeng-Chen wants to merge 2 commits into
Open
✨ Feat: add ASSET_OWNER role, enforce asset visibility, and refine no…#3042Lifeng-Chen wants to merge 2 commits into
Lifeng-Chen wants to merge 2 commits into
Conversation
…rthbound knowledge APIs
* Introduce ASSET_OWNER role with virtual tenant scope (asset_owner_tenant_id) and invitation bootstrap flow
* Add/adjust role permissions and tenant migrations for ASSET_OWNER-scoped resources (agents, skills, models, tools, invitations)
* Enforce visibility rules: hide ASSET_OWNER agent prompts for non-ASSET_OWNER callers (prompts_hidden) and restrict ASSET_OWNER skills/docs/files to asset-owner scope
* Tighten attachment access control for attachments/asset_owner/{user_id} while keeping knowledge_base files readable for authenticated users
* Refine /nb/v1/knowledge endpoints and parameters for index and file operations (list/create/delete indices, list files, delete documents, upload/download)
Merge develop's effectiveIndexName fallback for chunk CRUD/search APIs while keeping embedding model mismatch validation before hybrid search.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+152
to
+154
| return await ElasticSearchService.full_delete_knowledge_base( | ||
| index_name, vdb_core, ctx.user_id | ||
| ) |
Comment on lines
+353
to
+361
| content={ | ||
| "message": ( | ||
| "Files uploaded and processing triggered successfully" | ||
| ), | ||
| "uploaded_filenames": uploaded_filenames, | ||
| "uploaded_file_paths": uploaded_file_paths, | ||
| "errors": errors, | ||
| "process_tasks": process_result, | ||
| }, |
| if download == "redirect": | ||
| result = await get_file_url_impl( | ||
| object_name=object_name, expires=expires) | ||
| return RedirectResponse(url=result["url"]) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rthbound knowledge APIs