Dev/naming

[jgeudens]

Summary by CodeRabbit

• Chores
  • Updated continuous integration and deployment workflows
  • Disabled automated artifact uploads and deployment steps
  • Modified build system configuration and project naming
  • Removed code quality monitoring configuration
  • Updated development environment settings

[coderabbitai]

Walkthrough

These changes rename the project from ModbusScope to NotOnlyModbusScope, reset the version to 0.0.1, disable CI/CD deployment and artefact publishing, remove build analysis configuration, and truncate the changelog, indicating a project reset or restructuring phase.

Changes

Cohort / File(s)	Summary
CI/CD Pipeline .github/workflows/ccpp.yml, .github/workflows/doc.yml	Disabled automated artefact publishing for Linux and Windows builds, and disabled PDF manual upload to workflow artefacts.
Build and Project Configuration CMakeLists.txt, NotOnlyModbusScope.code-workspace	Updated project name from modbusscope to notonlymodbusscope, version reset to 0.0.1, and updated VS Code workspace folder reference for debugging.
Deployment Scripts scripts/full_build_and_deploy_windows.bat	Disabled Windows deployment step by commenting out the call to scripts\deploy_windows.bat.
Documentation and Code Quality CHANGELOG.md, sonar-project.properties	Removed extensive historical release notes and all entries except placeholder text; deleted entire SonarCloud configuration file.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'Dev/naming' is vague and uses non-descriptive terminology that doesn't clearly convey what was actually changed in the pull request.	Consider using a more descriptive title that summarises the main changes, such as 'Rename project from ModbusScope to NotOnlyModbusScope' or 'Update project naming and deployment configuration'.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch dev/naming

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (2)

.github/workflows/doc.yml (1)

18-23: Artifact upload disabled, but naming inconsistency remains.

The upload step is correctly disabled for the restructuring phase. However, line 18 still renames the PDF to modbusscope-user-manual.pdf. When re-enabling deployment, consider updating this to notonlymodbusscope-user-manual.pdf or similar to maintain consistency with the project rename.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In @.github/workflows/doc.yml around lines 18 - 23, Summary: The workflow still
renames the built PDF to modbusscope-user-manual.pdf despite the project rename;
update the target filename and corresponding artifact name when re-enabling
upload. Fix: Replace the mv target 'modbusscope-user-manual.pdf' in the mv
command with 'notonlymodbusscope-user-manual.pdf' (the source stays
'modbusscope.pdf'), and when you re-enable the commented upload-artifact step,
update the name and path fields from 'modbusscope-user-manual' and
'modbusscope-user-manual.pdf' to 'notonlymodbusscope-user-manual' and
'notonlymodbusscope-user-manual.pdf' so names stay consistent.

CHANGELOG.md (1)

6-18: Changelog reset to placeholders.

The placeholder entries (* xx) align with the version reset to 0.0.1. Consider documenting the project rename/restructuring in the "Changed" section to provide context for future readers:

### Changed

* Project renamed from ModbusScope to NotOnlyModbusScope
* Version reset to 0.0.1 for fresh start

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@CHANGELOG.md` around lines 6 - 18, Update the CHANGELOG.md "Changed" section
(the heading "### Changed") to replace the placeholder `* xx` with a concise
note documenting the project rename and version reset, e.g., mention "Project
renamed from ModbusScope to NotOnlyModbusScope" and "Version reset to 0.0.1 for
fresh start"; edit the entry under the "Changed" heading so the changelog
records these two points for future readers.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In @.github/workflows/doc.yml:
- Around line 18-23: Summary: The workflow still renames the built PDF to
modbusscope-user-manual.pdf despite the project rename; update the target
filename and corresponding artifact name when re-enabling upload. Fix: Replace
the mv target 'modbusscope-user-manual.pdf' in the mv command with
'notonlymodbusscope-user-manual.pdf' (the source stays 'modbusscope.pdf'), and
when you re-enable the commented upload-artifact step, update the name and path
fields from 'modbusscope-user-manual' and 'modbusscope-user-manual.pdf' to
'notonlymodbusscope-user-manual' and 'notonlymodbusscope-user-manual.pdf' so
names stay consistent.

In `@CHANGELOG.md`:
- Around line 6-18: Update the CHANGELOG.md "Changed" section (the heading "###
Changed") to replace the placeholder `* xx` with a concise note documenting the
project rename and version reset, e.g., mention "Project renamed from
ModbusScope to NotOnlyModbusScope" and "Version reset to 0.0.1 for fresh start";
edit the entry under the "Changed" heading so the changelog records these two
points for future readers.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 11fe8821-bf88-4c73-9dfc-3264a66d4aa2

📥 Commits

Reviewing files that changed from the base of the PR and between dc5d835 and dfe4875.

📒 Files selected for processing (7)

• .github/workflows/ccpp.yml
• .github/workflows/doc.yml
• CHANGELOG.md
• CMakeLists.txt
• NotOnlyModbusScope.code-workspace
• scripts/full_build_and_deploy_windows.bat
• sonar-project.properties

💤 Files with no reviewable changes (1)

• sonar-project.properties