Skip to content

feat: legacy router migration 4#131

Merged
Alessandro100 merged 6 commits intomainfrom
feat/26-legacy-router-migration-4
May 4, 2026
Merged

feat: legacy router migration 4#131
Alessandro100 merged 6 commits intomainfrom
feat/26-legacy-router-migration-4

Conversation

@Alessandro100
Copy link
Copy Markdown
Contributor

Summary:

closes #26

Removes the legacy router and all traces of the old React App

Expected behavior:

App should run as usual

Testing tips:

Provide tips, procedures and sample files on how to test the feature.
Testers are invited to follow the tips AND to try anything they deem relevant outside the bounds of the testing tips.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with yarn test to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@Alessandro100 Alessandro100 self-assigned this Apr 30, 2026
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 30, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
mobilitydatabase-web Ready Ready Preview, Comment Apr 30, 2026 5:30pm

Request Review

Co-authored-by: Copilot <copilot@github.com>
@github-actions
Copy link
Copy Markdown

*Lighthouse ran on https://mobilitydatabase-hb5qydjvn-mobility-data.vercel.app/ * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟢 98 🟢 94 🟢 96 🟢 100

*Lighthouse ran on https://mobilitydatabase-hb5qydjvn-mobility-data.vercel.app/feeds * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟠 82 🟠 87 🟢 96 🟢 100

*Lighthouse ran on https://mobilitydatabase-hb5qydjvn-mobility-data.vercel.app/feeds/gtfs/mdb-2126 * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟠 55 🟢 94 🟢 96 🟢 100

*Lighthouse ran on https://mobilitydatabase-hb5qydjvn-mobility-data.vercel.app/feeds/gtfs_rt/mdb-2585 * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟢 99 🟠 84 🟢 96 🟢 100

*Lighthouse ran on https://mobilitydatabase-hb5qydjvn-mobility-data.vercel.app/feeds/gbfs/gbfs-flamingo_porirua * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟢 95 🟢 94 🟢 96 🟢 100

@davidgamez davidgamez self-requested a review April 30, 2026 20:01
Comment thread src/app/[locale]/feeds/[feedDataType]/[feedId]/static/layout.tsx

// TODO: Once the [...slug] catch-all route is removed, replace this wrapper
// with a (protected) route group layout that provides auth guarding at the layout level.
// TODO: Replace this wrapper with a (protected) route group layout that
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have an issue for following up on this?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes we do #116

Comment thread src/app/components/ReduxGateWrapper.tsx
Comment thread package.json
Copy link
Copy Markdown
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Alessandro100 Alessandro100 merged commit 9b7e489 into main May 4, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SSR: Legacy Router Migration Split 4 (Cleanup)

2 participants