Skip to content

chore: prune unnecessary code (automated weekly cleanup)#166

Open
Miyamura80 wants to merge 1 commit into
mainfrom
chore-prune-unnecessary-code-14415639592093320777
Open

chore: prune unnecessary code (automated weekly cleanup)#166
Miyamura80 wants to merge 1 commit into
mainfrom
chore-prune-unnecessary-code-14415639592093320777

Conversation

@Miyamura80
Copy link
Copy Markdown
Owner

@Miyamura80 Miyamura80 commented May 13, 2026

This PR removes commented-out code from utils/llm/dspy_langfuse.py that is not used.
It strictly follows UNNECESSARY_CODE_GUIDELINE.md and only removes dead code that is safely identified as unused, leaving required Pydantic settings methods and test fixtures in place.


PR created automatically by Jules for task 14415639592093320777 started by @Miyamura80


Summary by cubic

Pruned commented-out dead code in utils/llm/dspy_langfuse.py to keep the file clean and reduce maintenance noise. No behavior or API changes.

  • Refactors
    • Removed commented cache_read_input_tokens fields and an unused status message update in on_lm_end.
    • Followed UNNECESSARY_CODE_GUIDELINE.md; left Pydantic settings and test fixtures intact.

Written for commit ac77f91. Summary will update on new commits.

- Remove commented-out dead code blocks in `utils/llm/dspy_langfuse.py` (lines 303, 320, 352).
- Ensure no test files, public APIs, or configuration settings are accidentally removed.

Co-authored-by: Miyamura80 <38335479+Miyamura80@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@qodo-code-review
Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Tip: cubic could auto-approve low-risk PRs like this, if it thinks it's safe to merge. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant