Skip to content

Enable BLE linting rule and add noqa comments for intentional exceptions #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Miyamura80 merged 1 commit into from
May 11, 2026
+3 −3
Merged

Enable BLE linting rule and add noqa comments for intentional exceptions #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ line-length = 88
target-version = "py312"

[tool.ruff.lint]
select = ["E", "F", "W", "I", "N", "UP", "B", "C4", "SIM", "C901", "FIX"]
select = ["E", "F", "W", "I", "N", "UP", "B", "C4", "SIM", "C901", "FIX", "BLE"]
ignore = ["E501", "UP015", "B008"]

[tool.ruff.lint.mccabe]
Expand Down
2 changes: 1 addition & 1 deletion tests/test_logging_thread_safety.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def call_setup():
try:
barrier.wait(timeout=5)
logging_module.setup_logging()
except Exception as e:
except Exception as e: # noqa: BLE001 - test collects any thread failure
errors.append(e)

threads = [threading.Thread(target=call_setup) for _ in range(10)]
Expand Down
2 changes: 1 addition & 1 deletion utils/llm/dspy_langfuse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ def on_module_end( # noqa
outputs_extracted = dict(outputs.items())
except AttributeError:
outputs_extracted = {"value": outputs}
except Exception as e:
except Exception as e: # noqa: BLE001 - observability fallback must never raise
outputs_extracted = {"error_extracting_module_output": str(e)}
get_client().update_current_span(
input=self.input_field_values.get(None) or {},
Expand Down
Loading