-
Notifications
You must be signed in to change notification settings - Fork 109
Feature/trade guide #6227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Feature/trade guide #6227
Changes from all commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
8dd1d36
Trade spot guide, refine wallet onboarding guides and spot trade limi…
SeniorZhai 26c5b84
Add pinch zoom to candle chart
SeniorZhai adb780b
Update guide style
SeniorZhai a68ed60
Add elevation to Button and create MixinButton component
SeniorZhai e625f6a
refactor: reuse mixin compose button
SeniorZhai 4d59c47
style: drop explicit normal button weights
SeniorZhai 262d179
fix: exclude zero-volume perps markets
SeniorZhai b1bc4fb
fix: convert perps market change to percentage correctly
SeniorZhai e3a451e
fix: use upsert to preserve rowid in perps tables
SeniorZhai 38d5ef5
refactor: unify perps market change percent calculation and formatting
SeniorZhai 2a46fa8
Merge branch 'fix/button-elevation' into feature/trde_guide
SeniorZhai 77a0081
Update strings
SeniorZhai ea18228
Revert small screen layout
SeniorZhai 6edfd9e
Merge branch 'fix/button-elevation' into feature/trde_guide
SeniorZhai 4511d64
feat: auto-set limit price 1% below market price
SeniorZhai f6757ab
Merge branch 'master' into feature/trde_guide
crossle c6809bc
fix limit order price shortcut direction
SeniorZhai a2033f0
refactor perps open position card layout
SeniorZhai 9eea336
Merge branch 'codex/perps-open-position-card-layout' into feature/trd…
SeniorZhai b1013b9
fix candle chart drag after zoom
SeniorZhai add5726
adjust candle chart price precision
SeniorZhai ef32d61
update guide navigation buttons
SeniorZhai d842b0c
Merge branch 'master' into feature/trde_guide
crossle 7f4ab6e
adjust spot guide example amounts
SeniorZhai 450a1d3
Update position card
SeniorZhai 587961c
fix web header icon for fixed title
SeniorZhai 14f9cf5
Update spot button
SeniorZhai 9543956
Update font weight
SeniorZhai e3f9c97
Update title
SeniorZhai 10c55d4
show trading guides once per category
SeniorZhai 239a409
Merge branch 'master' into feature/trde_guide
crossle 3ff0d8b
Update padding
SeniorZhai 4b8d482
fix button padding
crossle 732a88e
Revert "fix button padding"
crossle 351a264
Update padding
SeniorZhai 513285a
customize trade guide menu titles
SeniorZhai 8e8d54a
Update padding
SeniorZhai e645a70
Update horizontal arrangement
SeniorZhai 6c2b72b
Update horizontal arrangement
SeniorZhai fd544da
fix help menu text
crossle 83f5712
fix typo
crossle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -178,4 +178,3 @@ fun ClosedPositionItem( | |
| } | ||
| } | ||
|
|
||
| private const val SMALL_SCREEN_WIDTH_DP = 360 | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isPinchingis set totrueinsidedetectTransformGestures, but it is never reset tofalse. After the first pan/zoom gesture, the long-press crosshair (pointerInputbelow) andhorizontalScrollremain disabled permanently (enabled = !isTouching && !isPinching). Reset the flag when the transform gesture ends/cancels (or switch totransformableand use its in-progress state) so other interactions keep working.