Skip to content

Conversation

@benk-mira
Copy link
Contributor

@benk-mira benk-mira commented May 6, 2025

GEOPY-2088 - Application for surface normals to scatter point

@github-actions github-actions bot changed the title GEOPY-2088 GEOPY-2088: Application for surface normals to scatter point May 6, 2025
domfournier
domfournier previously approved these changes May 9, 2025
@domfournier
Copy link
Contributor

Can you see if you can just rely on geoh5py.merging.points.PointsMerger instead?

# Conflicts:
#	environments/py-3.10-linux-64-dev.conda.lock.yml
#	environments/py-3.10-linux-64.conda.lock.yml
#	environments/py-3.10-win-64-dev.conda.lock.yml
#	environments/py-3.10-win-64.conda.lock.yml
#	environments/py-3.11-linux-64-dev.conda.lock.yml
#	environments/py-3.11-linux-64.conda.lock.yml
#	environments/py-3.11-win-64-dev.conda.lock.yml
#	environments/py-3.11-win-64.conda.lock.yml
#	environments/py-3.12-linux-64-dev.conda.lock.yml
#	environments/py-3.12-linux-64.conda.lock.yml
#	environments/py-3.12-win-64-dev.conda.lock.yml
#	environments/py-3.12-win-64.conda.lock.yml
#	py-3.10.conda-lock.yml
#	py-3.11.conda-lock.yml
#	py-3.12.conda-lock.yml
@codecov
Copy link

codecov bot commented May 9, 2025

Codecov Report

Attention: Patch coverage is 86.27451% with 7 lines in your changes missing coverage. Please review.

Project coverage is 77.11%. Comparing base (03f19f3) to head (d9d30ce).
Report is 14 commits behind head on develop.

Files with missing lines Patch % Lines
surface_apps/surface_normals/driver.py 83.33% 3 Missing and 2 partials ⚠️
surface_apps/iso_surfaces/driver.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #35      +/-   ##
===========================================
+ Coverage    73.29%   77.11%   +3.82%     
===========================================
  Files            3        5       +2     
  Lines          191      236      +45     
  Branches        23       27       +4     
===========================================
+ Hits           140      182      +42     
- Misses          45       46       +1     
- Partials         6        8       +2     
Files with missing lines Coverage Δ
surface_apps/surface_normals/options.py 100.00% <100.00%> (ø)
surface_apps/iso_surfaces/driver.py 65.78% <60.00%> (+4.25%) ⬆️
surface_apps/surface_normals/driver.py 83.33% <83.33%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

domfournier
domfournier previously approved these changes May 9, 2025
@domfournier domfournier merged commit 2dab443 into develop May 12, 2025
14 checks passed
@domfournier domfournier deleted the GEOPY-2088 branch May 12, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants