Skip to content

[pre-commit.ci] pre-commit autoupdate #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebhmg merged 2 commits into from
Mar 7, 2025
Merged

[pre-commit.ci] pre-commit autoupdate #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9f57a2
[pre-commit.ci] pre-commit autoupdate
pre-commit-ci[bot] Mar 3, 2025
7bd0e24
fix mypy report
sebhmg Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ repos:
- id: pycln
args: [--config=pyproject.toml]
- repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.9.1
rev: v0.9.9
hooks:
- id: ruff
args:
Expand All @@ -28,7 +28,7 @@ repos:
- id: ruff-format
exclude: ^docs/
- repo: https://github.com/pre-commit/mirrors-mypy
rev: v1.14.1
rev: v1.15.0
hooks:
- id: mypy
additional_dependencies: [
Expand Down Expand Up @@ -61,7 +61,7 @@ repos:
types: [python]
exclude: ^(docs|surface_apps-assets)/
- repo: https://github.com/codespell-project/codespell
rev: v2.3.0
rev: v2.4.1
hooks:
- id: codespell
exclude: (-lock\.ya?ml|\benvironments/.*\.ya?ml|\.ipynb|^THIRD_PARTY_SOFTWARE\.rst)$
Expand Down
2 changes: 1 addition & 1 deletion surface_apps/iso_surfaces/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ def extract_iso_surfaces(
if level < np.nanmin(values) or level > np.nanmax(values):
skip += [level]
continue
verts, faces, _, _ = marching_cubes(values, level=level)
verts, faces, _normals, _values = marching_cubes(values, level=level)
verts, faces = remove_nan(verts, faces)

vertices = []
Expand Down