Skip to content

Allow users to bring their own libdave #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zfcmoe wants to merge 1 commit into from
Closed

Allow users to bring their own libdave #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions api/src/main/java/club/minnced/discord/jdave/utils/NativeLibraryLoader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,13 @@ public static Path createTemporaryFile() {

@NonNull
public static SymbolLookup getSymbolLookup() {
Path tempFile = createTemporaryFile();
return SymbolLookup.libraryLookup(tempFile, Arena.global());
String envPath = System.getenv().get("LIBDAVE_PATH");
Copy link
Copy Markdown
Owner

@MinnDevelopment MinnDevelopment Mar 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer using a system property for this.

Please also add some information about this to the readme.

if (envPath != null) {
return SymbolLookup.libraryLookup(envPath, Arena.global());
} else {
Path tempFile = createTemporaryFile();
return SymbolLookup.libraryLookup(tempFile, Arena.global());
}
}

@NonNull
Expand Down