Small formatting fixes (no code changes)#139
Closed
Jack1424 wants to merge 10 commits intoMilkBowl:masterfrom
Jack1424:format-fixes
Closed
Small formatting fixes (no code changes)#139Jack1424 wants to merge 10 commits intoMilkBowl:masterfrom Jack1424:format-fixes
Jack1424 wants to merge 10 commits intoMilkBowl:masterfrom
Jack1424:format-fixes
Conversation
Author
|
Also, I noticed that you used version 1.7 in the Maven and Gradle implementation examples even though 1.7.1 is available. I didn't know if I should change it, since it seems like Vault API should only be major.minor, unlike the Vault plugin. However, 1.7.1 is available in the repository. |
Jack1424
commented
Jun 28, 2022
Contributor
|
I'd wait till #138 gets merged until doing any changes |
Author
|
That's what I was thinking |
Jack1424
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to what I did with the main Vault repository, I did some grammar fixes and updated some links. I also fixed some indentation and spacing in configuration files and made tiny improvements to the publish script.