Skip to content

docs: clarify unit, coordinate system, and HID origin for LampInfo.Position and LampArray.BoundingBox - #2552

Draft
GrantMeStrength with Copilot wants to merge 2 commits into
docsfrom
copilot/fix-lampinfo-position-documentation
Draft

docs: clarify unit, coordinate system, and HID origin for LampInfo.Position and LampArray.BoundingBox#2552
GrantMeStrength with Copilot wants to merge 2 commits into
docsfrom
copilot/fix-lampinfo-position-documentation

Conversation

Copilot AI commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

LampInfo.Position and LampArray.BoundingBox lacked any specification of units, coordinate system handedness, axis orientation, or origin—forcing developers to reverse-engineer scale empirically.

lampinfo_position.md

  • Description now explicitly states values are in meters relative to the front-top-left corner of the bounding box
  • Property-value section describes each Vector3 axis (X=right, Y=down, Z=away from user)
  • New Remarks section covering:
    • Left-handed coordinate system with explicit +X/+Y/+Z directions
    • Origin definition: (0, 0, 0) = front-top-left corner of LampArray.BoundingBox
    • HID provenance: values converted from micrometers (µm ÷ 1,000,000) per the HID LampArray descriptor
  • See-also links added for BoundingBox, HID spec, and Dynamic lighting docs

lamparray_boundingbox.md

  • Added explicit left-handed coordinate system block with +X/+Y/+Z axis directions (parallel with Position page)
  • Added note that extents originate from the HID descriptor in micrometers, converted to meters by the WinRT layer

@prmerger-automator prmerger-automator Bot added do-not-merge PR is being processed and awaiting review/approval. review-team-triage labels Jul 27, 2026
Copilot AI linked an issue Jul 27, 2026 that may be closed by this pull request
Copilot AI changed the title [WIP] Fix missing unit specification for LampInfo.Position property docs: clarify unit, coordinate system, and HID origin for LampInfo.Position and LampArray.BoundingBox Jul 27, 2026
Copilot AI requested a review from GrantMeStrength July 27, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge PR is being processed and awaiting review/approval. review-team-triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing Unit Specification for LampInfo.Position

2 participants