Release Remove Taskif and Rohan JSON File - #10
Merged
Merged
Conversation
…Release-> merge all the devs update and run CI and check API Testing, Main-> run CI and CD. . and Upload Shihab API Testing File
There was a problem hiding this comment.
Pull request overview
This pull request introduces two Postman collection JSON files intended for API testing, but the PR title suggests these files should be removed—so the change intent needs clarification.
Changes:
- Added a Postman collection for FakeStore API authentication/products/carts/users requests (
api-testing-taskif.json). - Added a larger Postman collection covering multiple public APIs and mock endpoints (
api-testing-rohan.json).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| api-testing-taskif.json | Adds a FakeStore-focused Postman collection with auth + CRUD-style requests and tests. |
| api-testing-rohan.json | Adds a multi-API Postman collection with assorted requests and assertions (includes a JSON structure issue). |
Suppressed comments (1)
api-testing-taskif.json:47
- Hardcoded credentials are committed in this Postman collection. Even if these are demo accounts, it's safer to avoid storing usernames/passwords in-repo and require users to supply them via environment/collection variables.
"raw": "{\n \"username\": \"mor_2314\",\n \"password\": \"83r5^_\"\n}",
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+74
to
+76
| "pm.test(\"Status code is 200\", function () {", | ||
| " pm.response.to.have.status(200);", | ||
| "});" |
| @@ -0,0 +1,1240 @@ | |||
| { | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.