Use latest spot scoring time in tournament timeline#5015
Conversation
Compute the tournament timeline's "Last day for prize participation" marker from each question's spot_scoring_time (falling back to cp_reveal_time, matching the Question model default) and expose it as last_spot_scoring_time. The value is still the max across the tournament's questions, so only the latest date is shown. Co-authored-by: aseckin <3686968+aseckin@users.noreply.github.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🚀 Preview EnvironmentYour preview environment is ready!
Details
ℹ️ Preview Environment InfoIsolation:
Limitations:
Cleanup:
|
|
QA passed, pending code review |
Fixes #2492.
Summary
_calculate_timeline_datanow derives each question's contribution asquestion.spot_scoring_time or question.cp_reveal_time(mirroringQuestion.get_spot_scoring_time()and the model's documented fallback), and the returned field is renamedlast_cp_reveal_time→last_spot_scoring_time.TournamentTimelinetype andtournament_timeline.tsxto read the new field.The value is still the
maxacross the tournament's questions, so only the latest date is shown.Test plan
uv run ruff format .anduv run ruff check .cd front_end && bun run lintspot_scoring_timevalues and confirm the timeline chip sits on the latest one.Generated with Claude Code
Summary by CodeRabbit