Increase z-index of flow headers from z-50 to z-100#4490
Open
leonardthethird wants to merge 2 commits intomainfrom
Open
Increase z-index of flow headers from z-50 to z-100#4490leonardthethird wants to merge 2 commits intomainfrom
leonardthethird wants to merge 2 commits intomainfrom
Conversation
Add `isolate` to the main content container to create a new stacking context. This ensures chart elements (which use z-10 internally) cannot paint above the fixed z-50 header when scrolling. Fixes #4489 https://claude.ai/code/session_013ZzgDPESM7QDD6tyrUaqER
Raise the prediction flow header z-index from z-50 to z-100 to match the community header pattern. This prevents chart elements from painting above the fixed header when scrolling. Also revert the isolate approach in favor of this consistent pattern. Updates both the flow_header component and the loading skeleton. Fixes #4489 https://claude.ai/code/session_013ZzgDPESM7QDD6tyrUaqER
leonardthethird
temporarily deployed
to
testing_env
GitHub Actions
Inactive
Contributor
📝 WalkthroughWalkthroughTwo header components receive z-index value increases from 50 to 100 to adjust stacking order and ensure proper layering in the UI. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
🚀 Preview EnvironmentYour preview environment is ready!
Details
ℹ️ Preview Environment InfoIsolation:
Limitations:
Cleanup:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated the z-index stacking context for fixed header elements in the prediction flow from
z-50toz-100to ensure proper layering and prevent overlapping issues with other UI elements.Changes
z-50toz-100in the loading skeleton header (tournament/[slug]/prediction-flow/loading.tsx)z-50toz-100in the main flow header component (components/flow/flow_header.tsx)Details
Both fixed header elements that serve as the primary navigation/header in the prediction flow now use a higher z-index value (
z-100) to ensure they remain above other page content and modal overlays. This prevents potential z-stacking conflicts with other fixed or absolutely positioned elements on the page.Closes #4489
https://claude.ai/code/session_013ZzgDPESM7QDD6tyrUaqER
Summary by CodeRabbit