Skip to content

chore: change env vars#919

Merged
coodos merged 1 commit intomainfrom
feat/control-panel-env-vars
Mar 14, 2026
Merged

chore: change env vars#919
coodos merged 1 commit intomainfrom
feat/control-panel-env-vars

Conversation

@coodos
Copy link
Copy Markdown
Contributor

@coodos coodos commented Mar 14, 2026

Description of change

Issue Number

Type of change

  • Breaking (any change that would cause existing functionality to not work as expected)
  • New (a change which implements a new feature)
  • Update (a change which updates existing functionality)
  • Fix (a change which fixes an issue)
  • Docs (changes to the documentation)
  • Chore (refactoring, build scripts or anything else that isn't user-facing)

How the change has been tested

Change checklist

  • I have ensured that the CI Checks pass locally
  • I have removed any unnecessary logic
  • My code is well documented
  • I have signed my commits
  • My code follows the pattern of the application
  • I have self reviewed my code

Summary by CodeRabbit

  • Refactor
    • Updated internal environment configuration management across multiple services to use static environment imports, improving build-time optimization and configuration handling with no impact to user-facing functionality or behavior.

@coodos coodos merged commit 91d3c9f into main Mar 14, 2026
1 of 4 checks passed
@coodos coodos deleted the feat/control-panel-env-vars branch March 14, 2026 10:00
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 14, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 220a6d98-13fb-4e97-a221-62c9035240e4

📥 Commits

Reviewing files that changed from the base of the PR and between 37ecef2 and a0fddf4.

📒 Files selected for processing (8)
  • infrastructure/control-panel/src/lib/server/auth/allowlist.ts
  • infrastructure/control-panel/src/lib/server/auth/token.ts
  • infrastructure/control-panel/src/lib/services/loki.ts
  • infrastructure/control-panel/src/lib/services/notificationService.ts
  • infrastructure/control-panel/src/lib/services/registry.ts
  • infrastructure/control-panel/src/routes/api/auth/offer/+server.ts
  • infrastructure/control-panel/src/routes/api/evaults/+server.ts
  • infrastructure/control-panel/src/routes/api/references/+server.ts

📝 Walkthrough

Walkthrough

This PR systematically converts dynamic environment variable imports to static environment variable imports across authentication, service, and API route files in the control panel module. All function signatures and default fallback values are preserved.

Changes

Cohort / File(s) Summary
Auth & Private Config
infrastructure/control-panel/src/lib/server/auth/allowlist.ts, infrastructure/control-panel/src/lib/server/auth/token.ts, infrastructure/control-panel/src/routes/api/references/+server.ts
Replaced dynamic private environment imports with static private env imports for admin allowlist file path, JWT secret, and API credentials (base URL and API key).
Service Configuration
infrastructure/control-panel/src/lib/services/loki.ts, infrastructure/control-panel/src/lib/services/notificationService.ts, infrastructure/control-panel/src/lib/services/registry.ts
Switched from dynamic to static environment imports for Loki credentials, notification/provisioner service URLs, and registry configuration while maintaining existing fallback defaults.
API Routes
infrastructure/control-panel/src/routes/api/auth/offer/+server.ts, infrastructure/control-panel/src/routes/api/evaults/+server.ts
Updated dynamic public environment imports to static public env imports for control panel and registry URL resolution.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • refactor:control-panel #469: Introduces the static environment variable definitions that this PR now consumes across control-panel auth, service, and routing modules.

Poem

🐰 From dynamic winds to static ground,
Environment imports turn around!
Each service hops with fresher feet,
Configuration now static, clean and neat!

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/control-panel-env-vars
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant