Conversation
📝 WalkthroughWalkthroughThe PR modifies the sidebar component's responsive Tailwind CSS classes, adjusting the header element's width configuration and converting the bottom panel from fixed to sticky/static positioning across breakpoints to address sidebar centering issues on smaller screens. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Please only test the sidebar thing at your machine, lint errors are already resolved in another pr. |
2e8cb7b to
654b9da
Compare
654b9da to
fe779fa
Compare
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Fix all issues with AI agents
In `@docker-compose.core.yml`:
- Around line 36-74: The neo4j service healthcheck hard-codes the username ("-u
neo4j") so it will fail when NEO4J_USER is overridden; update the neo4j
healthcheck test command in the docker-compose block (healthcheck -> test) to
use the configured environment variable (NEO4J_USER with the same default)
instead of the literal "neo4j" (e.g., use ${NEO4J_USER:-neo4j}) so the
cypher-shell call uses the correct user; keep the existing password substitution
(${NEO4J_PASSWORD:-neo4j}) and the same CMD-SHELL form.
- Around line 76-98: The registry service's environment uses
DATABASE_URL=${REGISTRY_DATABASE_URL} which becomes empty when
REGISTRY_DATABASE_URL is unset; update the registry service (the registry block)
to require REGISTRY_DATABASE_URL at compose parse time by using Docker Compose's
required-variable substitution (make DATABASE_URL reference
REGISTRY_DATABASE_URL with the :? form and include a short error message) so the
stack fails fast with a clear message if REGISTRY_DATABASE_URL is missing.
In `@platforms/blabsy/src/components/sidebar/sidebar.tsx`:
- Around line 75-76: The className string in the Sidebar component (in
components/sidebar/sidebar.tsx) contains a stray double-quote inside the value
(the token `xl:w-72"`), making the Tailwind class invalid; fix it by editing the
className prop (the string containing 'flex shrink-0 w-16 ... xl:w-72"') and
remove the extra `"` so the token becomes `xl:w-72`, ensuring the className
string is a valid quoted string.
In `@platforms/eReputation/client/src/pages/dashboard.tsx`:
- Around line 545-553: The reference badge currently treats any
non-Revoked/Non-Pending status as "signed", which mislabels the new "Unknown"
default; update the JSX that renders the badge (the span inside the
activity.type === 'reference' / activity.activity checks) to explicitly check
for activity.status === 'Unknown' and render a neutral label like "unknown" with
gray/neutral borderBackground/color styles, adjust the conditional that sets the
label (replace the final 'signed' fallback) and the style ternaries to include
activity.status === 'Unknown' so it uses the neutral palette; make the same
change in the mirrored mobile badge block referenced around lines 633-641.
🧹 Nitpick comments (2)
infrastructure/evault-core/src/index.ts (1)
124-127: Make the Fastify body limit configurable via env.Hard-coding the limit makes environment tuning harder and risks drift vs infra/proxy caps. Consider reading from an env var with a safe default.
♻️ Suggested change
- fastifyServer = fastify({ - logger: true, - bodyLimit: 20 * 1024 * 1024, // 20MB (default is 1MB; needed for createMetaEnvelope etc.) - }); + const fastifyBodyLimit = + Number.parseInt(process.env.FASTIFY_BODY_LIMIT ?? "", 10) || + 20 * 1024 * 1024; + fastifyServer = fastify({ + logger: true, + bodyLimit: fastifyBodyLimit, + });infrastructure/evault-core/src/test-utils/e2e-setup.ts (1)
123-126: Reuse the same env-based body limit as production to avoid drift.This keeps E2E behavior aligned with runtime configuration and makes it easier to adjust limits centrally.
♻️ Suggested change
- const fastifyServer = fastify({ - logger: false, - bodyLimit: 20 * 1024 * 1024, // 20MB, match production limit - }); + const fastifyBodyLimit = + Number.parseInt(process.env.FASTIFY_BODY_LIMIT ?? "", 10) || + 20 * 1024 * 1024; + const fastifyServer = fastify({ + logger: false, + bodyLimit: fastifyBodyLimit, // match production limit + });
Description of change
Fixed Blabsy sidebar earlier it is floating to the middle of the small screens now fixed.
Issue Number
closes #742
Type of change
How the change has been tested
Manual
Change checklist
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.