Skip to content

Fix/esigner and ereference issues#736

Merged
coodos merged 3 commits intomainfrom
fix/esigner-and-ereference-issues
Jan 28, 2026
Merged

Fix/esigner and ereference issues#736
coodos merged 3 commits intomainfrom
fix/esigner-and-ereference-issues

Conversation

@coodos
Copy link
Copy Markdown
Contributor

@coodos coodos commented Jan 28, 2026

Description of change

  • Added private mapReferenceStatus(status) that maps: pending → "Pending", signed/active → "Signed", revoked → "Revoked", otherwise → "Unknown".
  • Replaced ref.status === 'revoked' ? 'Revoked' : 'Signed' with this.mapReferenceStatus(ref.status) for both sent and received reference activities in getActivities.
  • Page header: min-w-0 overflow-hidden on the header div, min-w-0 on h1.
  • Sidebar: min-w-0 on the sidebar and its inner content div.
  • Signature Container section: min-w-0 on the section and the Name block.
  • File Information: min-w-0 on the File Name row and on the span that shows file.name so truncate works in the flex row.
  • Selected File Info (step 2): container and flex row get min-w-0 overflow-hidden; icon flex-shrink-0; name wrapper min-w-0 flex-1 overflow-hidden; name

    uses truncate and title for full name.

  • File selection grid: card gets min-w-0 overflow-hidden; flex row and name wrapper get min-w-0 overflow-hidden; icon flex-shrink-0; title on the truncated name.
  • In getUserFiles, after building allFiles (owned + invited) and before the soft-delete filter, added:
  • Added UTC time disclaimer

Issue Number

closes #641
closes #640
closes #694
closes #693

Type of change

  • Fix (a change which fixes an issue)

Change checklist

  • I have ensured that the CI Checks pass locally
  • I have removed any unnecessary logic
  • My code is well documented
  • I have signed my commits
  • My code follows the pattern of the application
  • I have self reviewed my code

Summary by CodeRabbit

  • Bug Fixes

    • Fixed text overflow and layout handling in file details, file selection, and review screens for long filenames.
  • New Features

    • Files now sort by creation date (newest first).
    • Deadline messages now include an explicit UTC timezone indicator.
  • Refactor

    • Standardized reference status labels displayed in activity lists (e.g., Revoked, Signed, Pending).

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jan 28, 2026

📝 Walkthrough

Walkthrough

Refactors reference status mapping in the dashboard controller, sorts files by creation time in FileService, adds layout/truncation utility classes in eSigner UI pages, and standardizes UTC formatting (and optional voteId) in voting system messages.

Changes

Cohort / File(s) Summary
Dashboard status mapping
platforms/eReputation-api/src/controllers/DashboardController.ts
Adds private mapReferenceStatus(status: string): string and replaces inline ternaries in getActivities to use the mapper for sent and received reference status labels.
File list ordering (API)
platforms/esigner-api/src/services/FileService.ts
Applies a descending sort by creation time to getUserFiles so returned file lists show newest items first.
File UI layout / truncation (frontend)
platforms/esigner/src/routes/(protected)/files/[id]/+page.svelte, platforms/esigner/src/routes/(protected)/files/new/+page.svelte
Adds min-w-0 and overflow-hidden (and related layout tweaks) to containers and text nodes; uses truncated displayName/name with title attributes and shows file size for stable responsive layout.
Voting message UTC formatting
platforms/evoting-api/src/services/MessageService.ts
Introduces UTC_OPTIONS and renders deadlines with toLocaleDateString/toLocaleTimeString using UTC, appends " UTC"; updates createSystemMessage parameter type to accept optional voteId?: string.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

  • sosweetham
  • ananyayaya129

Poem

🐰 I nibble code with careful paws,

Statuses mapped without a pause,
Files now sorted, newest first in view,
Long names tuck in — neat and true,
Deadlines say "UTC" — a clearer muse.

🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Fix/esigner and ereference issues' is vague and generic, providing no specific information about the actual changes made. Replace with a more specific title describing the primary change, such as 'Fix reference status mapping and add UTC timezone handling' or similar.
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description is mostly complete with all required sections filled out including issue numbers, type of change, and checklist items, though some implementation details are incomplete.
Linked Issues check ✅ Passed The PR addresses all four linked issues: reference status mapping (#641), UTC time display (#640), file name overflow UI fixes (#694), and file sorting by creation time (#693).
Out of Scope Changes check ✅ Passed All code changes are directly related to the four linked issues; no out-of-scope modifications detected beyond the stated objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@platforms/evoting-api/src/services/MessageService.ts`:
- Around line 67-70: The deadline strings in createVoteCreatedMessage and
createVoteDeadlineMessage are labeled "UTC" but use
toLocaleDateString()/toLocaleTimeString() which honor server locale; change the
formatting to produce UTC timestamps explicitly (e.g., call
toLocaleDateString/toLocaleTimeString with the timeZone: 'UTC' option or
construct an ISO/UTC string) when building deadlineText and any other deadline
display so the displayed date/time actually reflects UTC.

@coodos coodos merged commit 2c10242 into main Jan 28, 2026
4 checks passed
@coodos coodos deleted the fix/esigner-and-ereference-issues branch January 28, 2026 08:41
coodos added a commit that referenced this pull request Jan 30, 2026
* fix: ereference & esigner cosmetic changes

* fix: UTC time instead of local

* fix: UTC time explicitly set at backend
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants