feat: Add Stellar to the known Snap derivation paths - #4097
Open
jeffnuclear wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Stellar to
SNAPS_DERIVATION_PATHSinsnaps-utils, so the permission prompt for Snaps requestingsnap_getBip32Entropyon the Stellar path shows "Manage Stellar accounts" instead of "Manage Unknown network m/44'/148' (ed25519) accounts".Also, adds a unit test covering the new entry.
Note
Low Risk
Small metadata and test-only change to derivation path labeling; no crypto or permission logic changes.
Overview
Registers Stellar (
m/44'/148',ed25519) inSNAPS_DERIVATION_PATHS, so Snap permission UI forsnap_getBip32Entropyon that path shows a friendly "Manage Stellar accounts" label instead of an unknown-network message.Because
getSnapDerivationPathNameonly falls back to SLIP-44 forsecp256k1, ed25519 coin types like Stellar must live in the hardcoded list. A unit test asserts the new mapping.Reviewed by Cursor Bugbot for commit 6316406. Bugbot is set up for automated code reviews on this repo. Configure here.