Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Contributor
Coverage Report
File CoverageNo changed files found. |
…ction deps Add a yarn constraint that errors when a published (`@metamask/`) package lists a private (`@ocap/`) workspace package in production dependencies (`dependencies` or `peerDependencies`) via the `workspace:` protocol. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
rekmarks
force-pushed
the
rekm/no-private-deps-in-public-packages
branch
from
a02f7a4 to
782e72c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@metamask/) packages from listing private (i.e., practically speaking,@ocap/) workspace packages in production dependencies (dependenciesorpeerDependencies) via theworkspace:protocolTest plan
yarn constraintspasses with no errors@ocap/package to a public package'sdependencieswithworkspace:^and verify the constraint catches it: see DO NOT MERGE: #865 test #867🤖 Generated with Claude Code
Note
Low Risk
Low risk: adds a Yarn constraints guardrail only, and it triggers only on invalid dependency declarations for published packages.
Overview
Adds a new Yarn constraint that fails
yarn constraintswhen a non-private (published) workspace declares aworkspace:protocol dependency on a private workspace in production dependency sections (anything other thandevDependencies, e.g.dependencies/peerDependencies).Implements
expectNoPrivateWorkspaceProductionDependenciesand runs it for all non-private child workspaces, emitting a clear error message naming the offending package and dependency type.Written by Cursor Bugbot for commit 782e72c. This will update automatically on new commits. Configure here.