feat: Persist pending messages and sequence state in RemoteHandle #760
+690
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| // Start ACK timeout if this is the first pending message | ||
| if (this.#pendingMessages.length === 1) { | ||
| this.#kernelStore.setRemoteStartSeq(this.remoteId, seq); | ||
| // Start ACK timeout for the first pending message |
There was a problem hiding this comment.
Crash-safe ordering persists startSeq too late
Medium Severity
The crash-safe write ordering persists setRemoteNextSendSeq before setRemoteStartSeq. If a crash occurs between these two writes when sending the first message, startSeq will default to 0 on recovery while nextSendSeq is correctly restored. The recovery code only repairs nextSendSeq (checking for message at nextSendSeq + 1), not startSeq. This causes #getPendingCount() to return an inflated value (e.g., 2 instead of 1), potentially causing premature rejection at MAX_PENDING_MESSAGES.
Additional Locations (1)
Remove in-memory pendingMessages array in favor of deriving queue state from persisted startSeq/nextSendSeq values. Messages are stored as plain strings without sendTimestamp. Implements crash-safe persistence for remote message queues (issue #691). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Fixes crash-safe write ordering bug where startSeq was persisted after nextSendSeq. Now: message → startSeq (if first) → nextSendSeq. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Scan for message at seq 1 even when getRemoteSeqState returns undefined. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
FUDCo
force-pushed
the
chip/persistent-message-queues
branch
from
abec9bf to
1d44443
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RemoteHandlestate (nextSendSeq, highestReceivedSeq, startSeq)Closes #691
Note
Implements durable, crash-safe sequencing for remote messaging and adds store APIs to support it.
RemoteHandlepending messages (as strings) and sequence state (nextSendSeq,highestReceivedSeq,startSeq) viaKernelStore; include persistence ofhighestReceivedSeqon receivenextSendSeq/startSeq, handle orphan messages); retransmit pending from storage with retry/timeout logic and queue capacity checksKernelStoremethods:get/setRemoteNextSendSeq,setRemoteHighestReceivedSeq,setRemoteStartSeq,get/set/deletePendingMessage,getRemoteSeqState,deleteRemotePendingState; ensure cleanup when deleting a remoteWritten by Cursor Bugbot for commit 1d44443. This will update automatically on new commits. Configure here.