-
Notifications
You must be signed in to change notification settings - Fork 7
refactor: Extract console-forwarding to kernel-browser-runtime utils #758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…e tests Add log capture for background service worker, offscreen document, and popup page console output during e2e tests. Logs are written to a timestamped file in <package>/logs/ and the path is attached to Playwright test results for easy access. Co-Authored-By: Claude <noreply@anthropic.com>
…ames Log files are now named with a run ID (timestamp of Playwright invocation) and test name to allow grouping logs from the same test run and easily identifying which test produced which logs. Format: <runId>-<testName>.log Co-Authored-By: Claude <noreply@anthropic.com>
Update yarn constraints to enforce ./logs in all workspace clean scripts, ensuring e2e test log files are cleaned up with other build artifacts. Co-Authored-By: Claude <noreply@anthropic.com>
Move console message forwarding functionality from the extension package to @metamask/kernel-browser-runtime as reusable utilities. This enables log capture from offscreen documents and other contexts via DuplexStream. - Create console-forwarding utilities with types and validators - Update extension to import from kernel-browser-runtime - Add console-forwarding exports to kernel-browser-runtime index Co-Authored-By: Claude <noreply@anthropic.com>
382c044 to
cad4772
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning MetaMask internal reviewing guidelines:
Ignoring alerts on:
|
|
@SocketSecurity ignore npm/playwright@1.57.0 |
Summary
Move console message forwarding functionality from the extension package to @metamask/kernel-browser-runtime as reusable utilities. This enables log capture from offscreen documents and other contexts via DuplexStream.
Changes
ConsoleForwardMessagetypeisConsoleForwardMessagetype guardmakeConsoleForwardingValidatorfactory functionsetupConsoleForwardingfunctionhandleConsoleForwardMessagefunctionBenefits
Test Plan
🤖 Generated with Claude Code