Skip to content

Conversation

@sirtimid
Copy link
Contributor

@sirtimid sirtimid commented Jan 13, 2026

Summary

  • Update @metamask/design-system-react from ^0.1.0 to ^0.6.0
  • Update @metamask/design-system-tailwind-preset from ^0.5.0 to ^0.6.1
  • Update @metamask/design-tokens from ^8.0.0 to ^8.1.1
  • Update react and react-dom from ^17.0.2 to ^18.3.1
  • Update @types/react and @types/react-dom to v18
  • Update @testing-library/react from ^12.1.5 to ^16.3.0 (removes need for separate @testing-library/react-hooks)
  • Update @radix-ui/react-slot to 1.2.4 (removes the yarn patch)

Code changes for React 18 compatibility

  • Use createRoot API instead of deprecated render in popup entry points
  • Explicitly type children prop in TableHeader component (React 18 no longer includes children implicitly in React.FC)
  • Update test imports from @testing-library/react-hooks to @testing-library/react
  • Update Vite config for React externals (function-based approach)

Test plan

  • yarn build passes
  • yarn test passes (3338 tests)
  • yarn test:e2e:ci passes (45 e2e tests across extension, nodejs, omnium-gatherum)

🤖 Generated with Claude Code


Note

Updates the UI stack to React 18 and the latest MetaMask design system, with necessary code/test and build config changes.

  • Upgrade react/react-dom (and types) to ^18.3.1; update @metamask/design-system-react ^0.6.0, @metamask/design-system-tailwind-preset ^0.6.1, @metamask/design-tokens ^8.1.1
  • Replace react-dom render with react-dom/client createRoot in extension and omnium-gatherum entrypoints; update corresponding tests
  • Migrate tests from @testing-library/react-hooks to @testing-library/react; tweak expectations and use renderHook from RTL
  • Kernel UI: explicitly type children in TableHeader, update peer deps to React 18, refine Vite externals for React, and Vitest config adds aliases/dep optimizer includes
  • Remove Yarn patch by resolving @radix-ui/react-slot to 1.2.4
  • Adjust repo coverage thresholds and refresh lockfile accordingly

Written by Cursor Bugbot for commit 79eb856. This will update automatically on new commits. Configure here.

@sirtimid sirtimid requested a review from a team as a code owner January 13, 2026 20:11
@sirtimid sirtimid force-pushed the sirtimid/update-design-system-react-18 branch from a9412a2 to 5873a04 Compare January 13, 2026 20:12
@socket-security
Copy link

socket-security bot commented Jan 13, 2026

@socket-security
Copy link

socket-security bot commented Jan 13, 2026

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring alerts on:

  • @metamask/design-system-shared@0.1.1
  • scheduler@0.23.2
  • react-dom@18.3.1
  • react@18.3.1
  • @types/react-dom@18.3.7
  • @metamask/design-tokens@8.1.1
  • @metamask/design-system-tailwind-preset@0.6.1
  • csstype@3.2.3
  • @types/react@18.3.27
  • @metamask/design-system-react@0.6.0
  • @testing-library/react@16.3.1

View full report

@sirtimid
Copy link
Contributor Author

@SocketSecurity ignore-all

@sirtimid sirtimid enabled auto-merge (squash) January 13, 2026 20:20
@sirtimid sirtimid force-pushed the sirtimid/update-design-system-react-18 branch from 8d8b33f to 78a3620 Compare January 14, 2026 17:06
sirtimid and others added 3 commits January 14, 2026 18:24
- Update @metamask/design-system-react: ^0.1.0 → ^0.6.0
- Update @metamask/design-system-tailwind-preset: ^0.5.0 → ^0.6.1
- Update @metamask/design-tokens: ^8.0.0 → ^8.1.1
- Update react and react-dom: ^17.0.2 → ^18.3.1
- Update @types/react and @types/react-dom to v18
- Update @testing-library/react: ^12.1.5 → ^16.3.0
- Update @radix-ui/react-slot: 1.2.3 → 1.2.4 (removes patch)

Code changes for React 18 compatibility:
- Use createRoot API instead of deprecated render
- Explicitly type children prop in TableHeader (React 18 change)
- Update test imports from @testing-library/react-hooks to @testing-library/react
- Update Vite config for React externals

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@sirtimid sirtimid force-pushed the sirtimid/update-design-system-react-18 branch from 78a3620 to 79eb856 Compare January 14, 2026 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants